Jack Phoenix has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312795
Change subject: Drop the IE-specific RL module
......................................................................
Drop the IE-specific RL module
The JS file never had any content and the CSS fixes in the CSS file were
apparently targeting IE7 or older -- that's the user agent the code in
ext.articleFeedbackv5.startup.js was checking for, except MediaWiki no
longer loads JS at all for IE8 and older.
The IE-specific RL module was added by Yoni in 09bc88f0cd5f back in
December 2011, and the only commits to the CSS file made by Sean were also
made very shortly after the addition of the module. Given how much the
browser support landscape has changed since late 2011, I think it's safe
to drop the CSS file, too.
Change-Id: Idad83e6b2aa50b7f966a2ed75c3d86a6942da981
---
M extension.json
D modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css
D modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js
M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
4 files changed, 0 insertions(+), 46 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5
refs/changes/95/312795/1
diff --git a/extension.json b/extension.json
index ac2a67b..ff6a358 100644
--- a/extension.json
+++ b/extension.json
@@ -138,10 +138,6 @@
"mediawiki.api"
]
},
- "ext.articleFeedbackv5.ie": {
- "scripts":
"ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js",
- "styles":
"ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css"
- },
"ext.articleFeedbackv5.dashboard": {
"scripts":
"ext.articleFeedbackv5/ext.articleFeedbackv5.dashboard.js",
"styles":
"ext.articleFeedbackv5/ext.articleFeedbackv5.dashboard.css",
diff --git a/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css
b/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css
deleted file mode 100644
index a24bba5..0000000
--- a/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css
+++ /dev/null
@@ -1,38 +0,0 @@
-.articleFeedbackv5-ui .articleFeedbackv5-submit {
- min-width: 190px;
-}
-.articleFeedbackv5-tags ul {
- margin: 0;
- padding: 0;
- display: block;
- list-style: none;
-}
-.articleFeedbackv5-tags ul li {
- margin: 0 2% 5px 0 !important;
- border: 0;
- list-style: none;
-}
-.articleFeedbackv5-tags ul li:first-child {
- margin: 0;
-}
-.articleFeedbackv5-tags ul li {
- display: block !important;
- float: left !important;
- width: 20% !important;
- white-space:nowrap;
- text-align: center;
- line-height: 18px !important;
-}
-.articleFeedbackv5-fixedtab {
- margin: 0 40px 0 0 !important;
- *margin: 0 !important;
- /*filter: progid:DXImageTransform.Microsoft.BasicImage(rotation=3);*/
-}
-.articleFeedbackv5-fixedtabbox {
-
-}
-.articleFeedbackv5-fixedtablink {
- /*position: absolute;*/
- *min-width: 0 !important;
- *display: block !important;
-}
\ No newline at end of file
diff --git a/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js
b/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js
deleted file mode 100644
index e69de29..0000000
--- a/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js
+++ /dev/null
diff --git a/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
b/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
index 176ff40..ca02536 100644
--- a/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
+++ b/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
@@ -41,10 +41,6 @@
// load AFTv5
mw.loader.load( 'ext.articleFeedbackv5' );
- // Load the IE-specific module
- if ( navigator.appVersion.indexOf( 'MSIE 7' ) !== -1 ) {
- mw.loader.load( 'ext.articleFeedbackv5.ie' );
- }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/312795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idad83e6b2aa50b7f966a2ed75c3d86a6942da981
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
