jenkins-bot has submitted this change and it was merged.
Change subject: DB: Replace begin with startAtomic and commit with endAtomic
......................................................................
DB: Replace begin with startAtomic and commit with endAtomic
Bug: T120791
Bug: T146598
Change-Id: Id169a4840d7a5cd6eb3ea98c23f5767f09fb66ee
---
M ActionDeletePagePermanently.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Paladox: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ActionDeletePagePermanently.php b/ActionDeletePagePermanently.php
index 4180809..767f011 100644
--- a/ActionDeletePagePermanently.php
+++ b/ActionDeletePagePermanently.php
@@ -69,7 +69,7 @@
$dbw = wfGetDB( DB_MASTER );
- $dbw->begin( __METHOD__ );
+ $dbw->startAtomic( __METHOD__ );
/*
* First delete entries, which are in direct relation with the
page:
@@ -214,11 +214,12 @@
# Delete image entry:
$dbw->delete( 'image', [ 'img_name' => $t ], __METHOD__
);
- $dbw->commit( __METHOD__ );
+ // $dbw->endAtomic( __METHOD__ );
$linkCache = LinkCache::singleton();
$linkCache->clear();
}
+ $dbw->endAtomic( __METHOD__ );
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/312797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id169a4840d7a5cd6eb3ea98c23f5767f09fb66ee
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/DeletePagesForGood
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
