Ryan Lane has submitted this change and it was merged. Change subject: Dont add LF to Subject: in gerrit notifications ......................................................................
Dont add LF to Subject: in gerrit notifications Workaround for Gerrit issue http://code.google.com/p/gerrit/issues/detail?id=1776 Our notification emails have subject line like this: Subject: =?UTF-8?Q?[Gerrit]_Update_pom_-_change_(mediawiki...mwdumper[master])=0A?= While it should be (in this case): Subject: [Gerrit] Update pom - change (mediawiki...mwdumper[master]) without extra LF at the end. Original (not customized) notification emails do not have this problem because the last token on the line is a macro call (#elipses). This is a Velocity Template Engine problem that should probably be worked around in Gerrit: https://issues.apache.org/jira/browse/VELOCITY-253 Change-Id: I893d8cfbd420888c346b3a305de0329f24e76ff4 --- M files/gerrit/mail/ChangeSubject.vm 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ryan Lane: Looks good to me, approved Demon: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/47343 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I893d8cfbd420888c346b3a305de0329f24e76ff4 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: saper <sa...@saper.info> Gerrit-Reviewer: Demon <ch...@wikimedia.org> Gerrit-Reviewer: Ryan Lane <rl...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
