Cenarium has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/313038

Change subject: Use RecentChange::addTags rather than ChangeTags::addTags
......................................................................

Use RecentChange::addTags rather than ChangeTags::addTags

To avoid consecutive DB writes on changetag table.
See I8df2fd983c12632337e8d2922fa357808482338c

Change-Id: Ib9393ed84979105694207abf4487824182dffa05
---
M WikimediaEventsHooks.php
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/38/313038/1

diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index 352accd..844e557 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -498,12 +498,7 @@
                if ( $bucket ) {
                        $tags[] = "cross-wiki-upload-$bucket";
                }
-               ChangeTags::addTags(
-                       $tags,
-                       $recentChange->getAttribute( 'rc_id' ),
-                       $recentChange->getAttribute( 'rc_this_oldid' ),
-                       $recentChange->getAttribute( 'rc_logid' )
-               );
+               $recentChange->addTags( $tags );
 
                return true;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/313038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9393ed84979105694207abf4487824182dffa05
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Cenarium <cenarium.sy...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to