[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Null out default config in tearDown

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/313135

Change subject: Null out default config in tearDown
......................................................................

Null out default config in tearDown

Change-Id: I2152fd99730b504d8d7f646fee6d077d9702244f
---
M Tests/BaseSmashPigUnitTestCase.php
M Tests/TestingConfiguration.php
2 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/35/313135/1

diff --git a/Tests/BaseSmashPigUnitTestCase.php 
b/Tests/BaseSmashPigUnitTestCase.php
index 90a6cf1..bc6cb9c 100644
--- a/Tests/BaseSmashPigUnitTestCase.php
+++ b/Tests/BaseSmashPigUnitTestCase.php
@@ -19,6 +19,7 @@
 
        function tearDown() {
                Context::set(); // Nullify the context for next run.
+               TestingConfiguration::tearDownConfiguration(); // And the 
default config
        }
 
        function loadJson( $path ) {
diff --git a/Tests/TestingConfiguration.php b/Tests/TestingConfiguration.php
index 0b8db27..c710566 100644
--- a/Tests/TestingConfiguration.php
+++ b/Tests/TestingConfiguration.php
@@ -2,6 +2,7 @@
 
 namespace SmashPig\Tests;
 
+use ReflectionClass;
 use SmashPig\Core\Configuration;
 
 /**
@@ -37,4 +38,11 @@
                $config->override( $data );
                return $config;
        }
+
+       public static function tearDownConfiguration() {
+               $konfig = new ReflectionClass( 'SmashPig\Core\Configuration' );
+               $defaultConfig = $konfig->getProperty( 'defaultObj' );
+               $defaultConfig->setAccessible( true );
+               $defaultConfig->setValue( null );
+       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/313135
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2152fd99730b504d8d7f646fee6d077d9702244f
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits