Ejegg has submitted this change and it was merged.

Change subject: Explicitly create test tables in sqlite
......................................................................


Explicitly create test tables in sqlite

Change-Id: Id48d5b2eeb84b8c181d2f9e0dcf2369ec7cebf0e
---
M PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Ejegg: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php 
b/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
index d74d7d1..2718fdb 100644
--- a/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
+++ b/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
@@ -35,6 +35,11 @@
        public function setUp() {
                parent::setUp();
                $this->config = PayPalTestConfiguration::get();
+
+               // php-queue\PDO complains about pop() from non-existent table
+               $this->config->object( 'data-store/jobs-paypal' )
+                       ->createTable( 'jobs-paypal' );
+
                Context::initWithLogger( $this->config );
                foreach ( self::$message_locations as $type => $file ) {
                        self::$messages[$type] = json_decode(
@@ -88,6 +93,7 @@
                        $job->execute();
 
                        $queue = $this->config->object( 'data-store/' . $type );
+                       $queue->createTable( $type );
                        $message = $queue->pop();
 
                        $this->assertNotEmpty( $message );

-- 
To view, visit https://gerrit.wikimedia.org/r/313127
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id48d5b2eeb84b8c181d2f9e0dcf2369ec7cebf0e
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to