Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/313337

Change subject: Logging for JobQueueConsumer
......................................................................

Logging for JobQueueConsumer

Change-Id: I9409efa602b076fc892f2e2d33acc633207f0bfd
---
M Core/QueueConsumers/JobQueueConsumer.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/37/313337/1

diff --git a/Core/QueueConsumers/JobQueueConsumer.php 
b/Core/QueueConsumers/JobQueueConsumer.php
index c96ad4e..bbc48e0 100644
--- a/Core/QueueConsumers/JobQueueConsumer.php
+++ b/Core/QueueConsumers/JobQueueConsumer.php
@@ -2,6 +2,7 @@
 
 use RuntimeException;
 use SmashPig\Core\DataStores\KeyedOpaqueStorableObject;
+use SmashPig\Core\Logging\Logger;
 use SmashPig\Core\Runnable;
 
 class JobQueueConsumer extends BaseQueueConsumer {
@@ -27,10 +28,15 @@
                // things as properties. The message is mingled with stuff like
                // php-message-class. Could collide.
                $className = $jobMessage['php-message-class'];
+               Logger::info( "Hydrating a message with class $className" );
+
                $jsonMessage = json_encode( $jobMessage );
+
+               Logger::debug( "Job payload: $jsonMessage" );
                $jobObj = KeyedOpaqueStorableObject::fromJsonProxy( $className, 
$jsonMessage );
 
                if ( $jobObj instanceof Runnable ) {
+                       Logger::info( 'Running job' );
                        if ( !$jobObj->execute() ) {
                                throw new RuntimeException(
                                        'Job tells us that it did not 
successfully execute. '

-- 
To view, visit https://gerrit.wikimedia.org/r/313337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9409efa602b076fc892f2e2d33acc633207f0bfd
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to