Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314584
Change subject: Fix volume resetting to 100% when starting playback
......................................................................
Fix volume resetting to 100% when starting playback
* mw.EmbedPlayerNative: Set the player volume when setting up
other stuff, after the player is inserted into DOM.
* mw.EmbedPlayer: Don't try to read current volume when the player
is not inserted, we get undefined and this breaks stuff later.
I am honestly not sure why we need this, but it seems to make sense
in context, together with all the other things that I'm not sure
why we need... and it seems to fix the issue.
Bug: T147449
Change-Id: I1e487f4659ce82b4eeec1445ac7dc65d2a053939
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js
2 files changed, 5 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/84/314584/1
diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
index 13a815b..1e89ca0 100644
--- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
+++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -2479,6 +2479,10 @@
// Update the previous volume
_this.previousVolume = _this.volume;
+ if ( !this.getPlayerElement() ) {
+ return
+ };
+
// Update the volume from the player element
_this.volume = this.getPlayerElementVolume();
diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js
b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js
index 8c514f7..c833c3d 100644
--- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js
+++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayerNative.js
@@ -266,6 +266,7 @@
}, 10 );
};
}
+ this.setPlayerElementVolume( this.volume );
// Some mobile devices ( iOS need a load call before play will
work )
if ( !_this.loop ) {
vid.load();
--
To view, visit https://gerrit.wikimedia.org/r/314584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e487f4659ce82b4eeec1445ac7dc65d2a053939
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
