Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/314849
Change subject: Use the transaction ticket provided by LinksUpdateComplete ...................................................................... Use the transaction ticket provided by LinksUpdateComplete Change-Id: I119978c8afac818ef210b19e0c893cf3d2ce3a4e --- M PageAssessments.hooks.php M PageAssessmentsBody.php 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments refs/changes/49/314849/1 diff --git a/PageAssessments.hooks.php b/PageAssessments.hooks.php index 644fe1c..5c6dd5c 100644 --- a/PageAssessments.hooks.php +++ b/PageAssessments.hooks.php @@ -33,8 +33,9 @@ /** * Insert assessment records after page is saved * @param LinksUpdate $linksUpdate + * @param mixed $ticket */ - public static function onLinksUpdateComplete( &$linksUpdate ) { + public static function onLinksUpdateComplete( &$linksUpdate, $ticket = null ) { $pOut = $linksUpdate->getParserOutput(); if ( $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ) !== null ) { $assessmentData = $pOut->getExtensionData( 'ext-pageassessment-assessmentdata' ); @@ -47,7 +48,7 @@ // In most cases $title will be a talk page, but we want to associate the // assessment data with the subject page. $subjectTitle = $title->getSubjectPage(); - PageAssessmentsBody::doUpdates( $subjectTitle, $assessmentData ); + PageAssessmentsBody::doUpdates( $subjectTitle, $assessmentData, $ticket ); } /** diff --git a/PageAssessmentsBody.php b/PageAssessmentsBody.php index e9dee64..cc19ce8 100644 --- a/PageAssessmentsBody.php +++ b/PageAssessmentsBody.php @@ -33,12 +33,13 @@ * Driver function that handles updating assessment data in database * @param Title $titleObj Title object of the subject page * @param array $assessmentData Data for all assessments compiled + * @param mixed $ticket Transaction ticket */ - public static function doUpdates( $titleObj, $assessmentData ) { + public static function doUpdates( $titleObj, $assessmentData, $ticket = null ) { global $wgUpdateRowsPerQuery; $factory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory(); - $ticket = $factory->getEmptyTransactionTicket( __METHOD__ ); + $ticket = $ticket ?: $factory->getEmptyTransactionTicket( __METHOD__ ); $pageId = $titleObj->getArticleID(); $revisionId = $titleObj->getLatestRevID(); -- To view, visit https://gerrit.wikimedia.org/r/314849 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I119978c8afac818ef210b19e0c893cf3d2ce3a4e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageAssessments Gerrit-Branch: master Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits