jenkins-bot has submitted this change and it was merged. Change subject: mediawiki.UI: Document explicitly about deprecated .mw-ui-constructive ......................................................................
mediawiki.UI: Document explicitly about deprecated .mw-ui-constructive Changing documentation in mediawiki.UI anchors about deprecated `.mw-ui-constructive` class. Bug: T146923 Change-Id: If3686c7c9c071fa708ae1deb82aa465a1f390175 --- M resources/src/mediawiki.ui/components/anchors.less 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/src/mediawiki.ui/components/anchors.less b/resources/src/mediawiki.ui/components/anchors.less index 5bb69b8..4c4e129 100644 --- a/resources/src/mediawiki.ui/components/anchors.less +++ b/resources/src/mediawiki.ui/components/anchors.less @@ -6,15 +6,14 @@ .mixin-mw-ui-anchor-styles( @mainColor ) { color: @mainColor; - // Hover state &:hover { color: lighten( @mainColor, @colorLightenPercentage ); } - // Focus and active states + &:focus, &:active { color: darken( @mainColor, @colorDarkenPercentage ); - outline: none; // outline fix + outline: 0; } // Quiet mode is gray at first @@ -26,13 +25,13 @@ /* Anchors -The anchor base type can be applied to A elements when a basic context styling needs to be given to a link, without -having to assign it as a button type. mw-ui-anchor only changes the text color, and should not be used in combination -with other base classes, such as mw-ui-button. +The anchor base type can be applied to `a` elements when a basic context styling needs to be given to a link, without +having to assign it as a button type. `.mw-ui-anchor` only changes the text color, and should not be used in combination +with other base classes, such as `.mw-ui-button`. + Markup: <a href="#" class="mw-ui-anchor mw-ui-progressive">Progressive</a> -<a href="#" class="mw-ui-anchor mw-ui-constructive">Constructive</a> <a href="#" class="mw-ui-anchor mw-ui-destructive">Destructive</a> .mw-ui-quiet - Quiet until interaction. @@ -46,13 +45,14 @@ .mixin-mw-ui-anchor-styles( @colorProgressive ); } - &.mw-ui-constructive { - .mixin-mw-ui-anchor-styles( @colorConstructive ); - } - &.mw-ui-destructive { .mixin-mw-ui-anchor-styles( @colorDestructive ); } + + //`.mw-ui-constructive` is deprecated; consolidated with `progressive`, see T110555 + &.mw-ui-constructive { + .mixin-mw-ui-anchor-styles( @colorConstructive ); + } } /* -- To view, visit https://gerrit.wikimedia.org/r/315197 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3686c7c9c071fa708ae1deb82aa465a1f390175 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: VolkerE <volke...@wikimedia.org> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits