Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315318
Change subject: Remove MinervaBottomLanguageButton
......................................................................
Remove MinervaBottomLanguageButton
The language button will show at the top of the page
for all pages except the main page where it will
show at the bottom of the page.
Depends-On: I1ac608388ec674e0f315c08208a66d299917a678
Bug: T143829
nervaBottomLanguageButton
Change-Id: Ic1b81e142724030992e8b567b821c20a85dcb254
---
M README.md
M extension.json
M includes/skins/SkinMinerva.php
3 files changed, 1 insertion(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/18/315318/1
diff --git a/README.md b/README.md
index 8b5fd92..7a2ab8a 100644
--- a/README.md
+++ b/README.md
@@ -249,15 +249,6 @@
* Type: `String`
* Default: `'X-WAP'`
-#### $wgMinervaBottomLanguageButton
-
-Whether the language button at the bottom of the page is enabled
-
-Whether to show the language switcher button even if no languages are
available for the page.
-
-* Type: `Boolean`
-* Default: `true`
-
#### $wgMinervaUseFooterV2
A temporary configuration variable to control display of a new footer which
impacts styling
diff --git a/extension.json b/extension.json
index f3f9576..bf6aee2 100644
--- a/extension.json
+++ b/extension.json
@@ -2048,7 +2048,6 @@
"MFSchemaEditSampleRate": 0.0625,
"MFAllowNonJavaScriptEditing": false,
"MinervaAlwaysShowLanguageButton": true,
- "MinervaBottomLanguageButton": true,
"MinervaUseFooterV2": false,
"MFStripResponsiveImages": true,
"MFResponsiveImageWhitelist": [
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 189b639..63dcc20 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -936,8 +936,7 @@
}
}
- if ( MobileContext::singleton()->getMFConfig()->get(
'MinervaBottomLanguageButton' ) &&
- $this->doesPageHaveLanguages &&
+ if ( $this->doesPageHaveLanguages &&
( $title->isMainPage() ||
$this->shouldSecondaryActionsIncludeLanguageBtn ) ) {
$buttons['language'] = $this->getLanguageButton();
}
--
To view, visit https://gerrit.wikimedia.org/r/315318
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1b81e142724030992e8b567b821c20a85dcb254
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
