jenkins-bot has submitted this change and it was merged.
Change subject: Compute and cache directionality once
......................................................................
Compute and cache directionality once
Computed CSS ($.css) is relatively slow, and directionality
should never change, so just compute it once.
Change-Id: I6519fa7f54599c498e22a348dfaedd940c860955
---
M modules/ext.RevisionSlider.SliderView.js
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index 090ceac..5b49fe8 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -73,6 +73,11 @@
*/
noMoreOlderRevisions: false,
+ /**
+ * @type {string}
+ */
+ dir: null,
+
render: function ( $container ) {
var containerWidth =
this.calculateSliderContainerWidth(),
pointerContainerPosition = 53,
@@ -88,7 +93,9 @@
forwardArrowPopup,
self = this;
- if ( $slider.css( 'direction' ) === 'rtl' ) {
+ this.dir = $container.css( 'direction' ) || 'ltr';
+
+ if ( this.dir === 'rtl' ) {
this.rtlScrollLeftType =
this.determineRtlScrollType();
}
@@ -161,7 +168,7 @@
.focusin( { button: this.forwardArrowButton },
this.arrowFocusHandler );
pointerContainerStyle = { left:
pointerContainerPosition + 'px', width: pointerContainerWidth + 'px' };
- if ( $slider.css( 'direction' ) === 'rtl' ) {
+ if ( this.dir === 'rtl' ) {
// Due to properly limit dragging a pointer on
the right side of the screen,
// there must some extra space added to the
right of the revision bar container
// For this reason right position of the
pointer container in the RTL mode is
@@ -200,7 +207,7 @@
var $p = $( this ),
pointer = self.whichPointer( $p
),
pos = parseInt( $p.css( 'left'
), 10 ),
- adjustedPos =
$p.offsetParent().css( 'direction' ) === 'rtl' ?
pointer.getView().getAdjustedLeftPositionWhenRtl( pos ) : pos,
+ adjustedPos = self.dir ===
'rtl' ? pointer.getView().getAdjustedLeftPositionWhenRtl( pos ) : pos,
relativeIndex = Math.ceil( (
adjustedPos + self.revisionWidth / 2 ) / self.revisionWidth ),
revId1, revId2;
mw.track(
'counter.MediaWiki.RevisionSlider.event.pointerMove' );
@@ -220,7 +227,7 @@
drag: function ( event, ui ) {
var newestVisibleRevisionLeftPos = $(
'.mw-revslider-revisions-container' ).width() - self.revisionWidth;
ui.position.left = Math.min(
ui.position.left, newestVisibleRevisionLeftPos );
- if ( $( this ).css( 'direction' ) ===
'ltr' ) {
+ if ( self.dir === 'ltr' ) {
self.resetPointerColorsBasedOnValues(
self.pointerOlder.getView().getElement().offset().left,
self.pointerNewer.getView().getElement().offset().left
@@ -503,7 +510,7 @@
}
animateObj = { scrollLeft:
this.slider.getFirstVisibleRevisionIndex() * this.revisionWidth };
- if ( this.$element.css( 'direction' ) === 'rtl' ) {
+ if ( this.dir === 'rtl' ) {
animateObj.scrollLeft = this.getRtlScrollLeft(
$animatedElement, animateObj.scrollLeft );
}
@@ -769,7 +776,7 @@
scrollLeft = this.slider.getFirstVisibleRevisionIndex()
* this.revisionWidth;
$revisionContainer.scrollLeft( scrollLeft );
- if ( this.$element.css( 'direction' ) === 'rtl' ) {
+ if ( this.dir === 'rtl' ) {
$revisionContainer.scrollLeft(
self.getRtlScrollLeft( $revisionContainer, scrollLeft ) );
}
--
To view, visit https://gerrit.wikimedia.org/r/315618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6519fa7f54599c498e22a348dfaedd940c860955
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
