jenkins-bot has submitted this change and it was merged.

Change subject: linter: Get rid of tips
......................................................................


linter: Get rid of tips

These tips are hardcoded English, so they aren't suitable for display.
The MediaWiki extension will contain its own tips that are localized.

Change-Id: Ife7886b0c332ec6592663f2d115e3314e3a71eb0
---
M lib/logger/linter.js
M lib/wt2html/pp/handlers/linter.js
2 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Arlolra: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/logger/linter.js b/lib/logger/linter.js
index 7a8b5e6..3ac42d6 100644
--- a/lib/logger/linter.js
+++ b/lib/logger/linter.js
@@ -84,10 +84,6 @@
                        msg.src = src.substring(dsr[0], dsr[1]);
                }
 
-               if (logData.logObject[2]) {
-                       msg.tips = logData.tip;
-               }
-
                this.buffer.push(msg);
 
        } catch (e) {
diff --git a/lib/wt2html/pp/handlers/linter.js 
b/lib/wt2html/pp/handlers/linter.js
index 0188365..1ea45ed 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -95,7 +95,6 @@
                        lintObj = {
                                src: env.page.src,
                                dsr: dsr,
-                               tip: 'Add End Tag to Fix this',
                                inTransclusion: inTransclusion,
                        };
                        env.log('lint/missing-end-tag', lintObj);
@@ -105,7 +104,6 @@
                        lintObj = {
                                src: env.page.src,
                                dsr: dsr,
-                               tip: 'Add Start Tag to Fix this',
                                inTransclusion: inTransclusion,
                        };
                        env.log('lint/missing-start-tag', lintObj);

-- 
To view, visit https://gerrit.wikimedia.org/r/316019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife7886b0c332ec6592663f2d115e3314e3a71eb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to