Adamw has uploaded a new change for review. Change subject: All banner JS is contained elsewhere ......................................................................
All banner JS is contained elsewhere We want strict code review of javascript. A new field is defined on banners, which names a message to inline as raw javascript when rendering from Special:BannerLoader. The name given is prepended with "MediaWiki:Centralnotice-bannerjs-" to find the message. Inlining js in the banner body will be discouraged for now, and eventually we will prevent it. My recommendation for code reviewing these messages is to inculcate social conventions, for now. We should require that any bannerjs is documented-- the Discussion tab would serve well--and that page will include an audit log explaining which revisions have been okayed, and by whom. TODO: * This schema update should be merged with the others on the "templates" table. * Log tab for bannerjs content changes. Integrate with "banner settings" pager when the banner's js message name is changed. Change-Id: I9e4ad39fb8e8685eae70fd30ed3f06df544a0ce6 --- M CentralNotice.db.php M CentralNotice.i18n.php M CentralNotice.php A patches/patch-template_bannerjs.sql M special/SpecialBannerLoader.php M special/SpecialNoticeTemplate.php 6 files changed, 47 insertions(+), 34 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/22/48122/1 -- To view, visit https://gerrit.wikimedia.org/r/48122 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e4ad39fb8e8685eae70fd30ed3f06df544a0ce6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Adamw <awi...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
