Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316998

Change subject: Hygiene: suppress lints for lib resource overrides
......................................................................

Hygiene: suppress lints for lib resource overrides

HockeyApp library strings and Onboarding tool tip drawables are
overridden but Lint can't detect that and emits a warning. There are
hundreds of string translations and so hundreds of warnings. Suppress
the UnusedResources warning for only these resources.

Change-Id: I48de1f9ac92cfb74535bcef63d92513291f52a60
---
M app/lint.xml
D app/src/main/res/anim/fade_in.xml
D app/src/main/res/anim/fade_out.xml
3 files changed, 6 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/98/316998/1

diff --git a/app/lint.xml b/app/lint.xml
index 178281c..b58940a 100644
--- a/app/lint.xml
+++ b/app/lint.xml
@@ -13,4 +13,9 @@
         <ignore path="res/drawable/lead_default_dark.png" />
         <ignore path="res/drawable/wp_wordmark.png" />
     </issue>
-</lint>
+
+    <issue id="UnusedResources">
+        <ignore regexp="crash_report_dialog_[a-z_]+" />
+        <ignore regexp="tool_tip_arrow_[updown]+" />
+    </issue>
+</lint>
\ No newline at end of file
diff --git a/app/src/main/res/anim/fade_in.xml 
b/app/src/main/res/anim/fade_in.xml
deleted file mode 100644
index 5d274c6..0000000
--- a/app/src/main/res/anim/fade_in.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android";
-    android:interpolator="@android:interpolator/decelerate_quad"
-    android:fromAlpha="0.0" android:toAlpha="1.0"
-    android:duration="@android:integer/config_shortAnimTime" />
diff --git a/app/src/main/res/anim/fade_out.xml 
b/app/src/main/res/anim/fade_out.xml
deleted file mode 100644
index 193b69d..0000000
--- a/app/src/main/res/anim/fade_out.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<alpha xmlns:android="http://schemas.android.com/apk/res/android";
-    android:interpolator="@android:interpolator/accelerate_quad"
-    android:fromAlpha="1.0" android:toAlpha="0.0"
-    android:duration="@android:integer/config_shortAnimTime" />

-- 
To view, visit https://gerrit.wikimedia.org/r/316998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I48de1f9ac92cfb74535bcef63d92513291f52a60
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to