Brian Wolff has submitted this change and it was merged. Change subject: (bug 43801) add a getter for ICU version to ICUCollation ......................................................................
(bug 43801) add a getter for ICU version to ICUCollation It will be necessary to be able to use correct version of Unicode data files. The constant INTL_ICU_VERSION this getter returns isn't really documented. It is available since PHP 5.3.7 (see PHP bug 54561), the getter will fail gracefully on older PHPs. It should be possible to determine the ICU version on these by grepping the output of phpinfo(), but I don't think such a minor improvement is worth such a huge hack. Change-Id: I85353559439bfddee7c5ba90894d30dd8ef0e0e8 --- M includes/Collation.php M maintenance/language/generateCollationData.php 2 files changed, 107 insertions(+), 10 deletions(-) Approvals: Brian Wolff: Looks good to me, approved Matmarex: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/44734 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85353559439bfddee7c5ba90894d30dd8ef0e0e8 Gerrit-PatchSet: 14 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex <matma....@gmail.com> Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com> Gerrit-Reviewer: Matmarex <matma....@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
