jenkins-bot has submitted this change and it was merged.
Change subject: Don't delete pending data for failed:review
......................................................................
Don't delete pending data for failed:review
'Failed' is correct as far as the front-end goes, but when the
payment is in review, Donor Services might push it through manually.
We should leave donor details unless it's been rejected with finality.
Bug: T148859
Change-Id: Ic415217fd1fe4d2ecfbb5c53f93a1ce619cfd856
---
M sites/all/modules/queue2civicrm/fredge/PaymentsInitQueueConsumer.php
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
Cdentinger: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/sites/all/modules/queue2civicrm/fredge/PaymentsInitQueueConsumer.php
b/sites/all/modules/queue2civicrm/fredge/PaymentsInitQueueConsumer.php
index 9590deb..334120d 100644
--- a/sites/all/modules/queue2civicrm/fredge/PaymentsInitQueueConsumer.php
+++ b/sites/all/modules/queue2civicrm/fredge/PaymentsInitQueueConsumer.php
@@ -28,8 +28,17 @@
// Delete corresponding pending rows if this contribution
failed.
// The DonationQueueConsumer will delete pending rows for
successful
// contributions, and we don't want to be too hasty.
- if ( $message['payments_final_status'] === 'failed' ) {
- watchdog( 'fredge', "Deleting pending row for failed
message {$logId}", array(), WATCHDOG_INFO );
+ // Leave details for payments still open for manual review.
+ if (
+ $message['payments_final_status'] === 'failed' &&
+ $message['validation_action'] === 'reject'
+ ) {
+ watchdog(
+ 'fredge',
+ "Deleting pending row for failed and rejected
payment {$logId}",
+ array(),
+ WATCHDOG_INFO
+ );
PendingDatabase::get()->deleteMessage( $message );
}
--
To view, visit https://gerrit.wikimedia.org/r/317189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic415217fd1fe4d2ecfbb5c53f93a1ce619cfd856
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
