Arlolra has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317668
Change subject: Don't normalize away null values
......................................................................
Don't normalize away null values
* An MWOAuthConsumer is often initialized w/ id == null so that the
field autoincrements when being inserted. Normalizing to an int
converts the value to 0, which doesn't play nice w/ sqlite.
* Maybe a better solution is to explicitly set the field to null in the
row before inserting, and keeping this normalization?
Change-Id: I06858d50687efdb94c76c6e9360185138449d24e
---
M backend/MWOAuthConsumer.php
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth
refs/changes/68/317668/1
diff --git a/backend/MWOAuthConsumer.php b/backend/MWOAuthConsumer.php
index d63fde3..f0ba256 100644
--- a/backend/MWOAuthConsumer.php
+++ b/backend/MWOAuthConsumer.php
@@ -269,7 +269,6 @@
}
protected function normalizeValues() {
- $this->id = (int)$this->id;
$this->userId = (int)$this->userId;
$this->registration = wfTimestamp( TS_MW, $this->registration );
$this->stage = (int)$this->stage;
--
To view, visit https://gerrit.wikimedia.org/r/317668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06858d50687efdb94c76c6e9360185138449d24e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Arlolra <abrea...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
