jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: suppress autoMirrored API level warnings ......................................................................
Hygiene: suppress autoMirrored API level warnings We should commit to ignoring these warnings or fixing them on API 18 and 19. From the docs[0]: On previous versions of Android, if your app includes images that should reverse their horizontal orientation for right-to-left layouts, you must include the mirrored image in a drawables-ldrtl/ resource directory. This patch takes the ignore route because it's easy and uses less space. [0] https://developer.android.com/about/versions/android-4.4.html#DrawableMirroring Change-Id: I09a0d8427bda1b4e4c1d2fa1e0df36d7aca57f09 --- M app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml M app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml M app/src/main/res/drawable/ic_file_download.xml M app/src/main/res/drawable/ic_find_in_page.xml M app/src/main/res/drawable/ic_flag_black_24dp.xml M app/src/main/res/drawable/ic_image_gray_24dp.xml M app/src/main/res/drawable/ic_list_white_24dp.xml M app/src/main/res/drawable/ic_mode_edit_white_24dp.xml M app/src/main/res/drawable/ic_most_read.xml M app/src/main/res/drawable/ic_restore_black_24dp.xml M app/src/main/res/drawable/ic_share_black_24dp.xml M app/src/main/res/drawable/ic_share_white_24dp.xml M app/src/main/res/drawable/ic_sort_white_24dp.xml M app/src/main/res/drawable/ic_subdirectory_arrow_right_black_24dp.xml M app/src/main/res/drawable/ic_translate_white_24dp.xml M app/src/main/res/drawable/icon_in_the_news.xml 16 files changed, 65 insertions(+), 33 deletions(-) Approvals: Mholloway: Looks good to me, but someone else must approve Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml b/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml index 0d8872d..7cda61b 100644 --- a/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml +++ b/app/src/main/res/drawable/ic_arrow_forward_black_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#f666" android:pathData="M12,4l-1.41,1.41L16.17,11H4v2h12.17l-5.58,5.59L12,20l8,-8z"/> </vector> diff --git a/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml b/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml index c89a4ed..5b78ab9 100644 --- a/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml +++ b/app/src/main/res/drawable/ic_collections_bookmark_black_24dp.xml @@ -1,9 +1,11 @@ <vector xmlns:android="http://schemas.android.com/apk/res/android"; - android:autoMirrored="true" - android:width="24dp" - android:height="24dp" - android:viewportWidth="24.0" - android:viewportHeight="24.0"> + xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" + android:width="24dp" + android:height="24dp" + android:viewportWidth="24.0" + android:viewportHeight="24.0" + tools:ignore="UnusedAttribute"> <path android:fillColor="#FF000000" android:pathData="M4,6L2,6v14c0,1.1 0.9,2 2,2h14v-2L4,20L4,6zM20,2L8,2c-1.1,0 -2,0.9 -2,2v12c0,1.1 0.9,2 2,2h12c1.1,0 2,-0.9 2,-2L22,4c0,-1.1 -0.9,-2 -2,-2zM20,12l-2.5,-1.5L15,12L15,4h5v8z"/> diff --git a/app/src/main/res/drawable/ic_file_download.xml b/app/src/main/res/drawable/ic_file_download.xml index da16642..87dad3f 100644 --- a/app/src/main/res/drawable/ic_file_download.xml +++ b/app/src/main/res/drawable/ic_file_download.xml @@ -1,6 +1,8 @@ -<vector android:autoMirrored="true" android:height="17dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="17dp" android:viewportHeight="17.0" android:viewportWidth="14.0" - android:width="14dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="14dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#71777D" android:pathData="M14,6L10,6L10,0L4,0L4,6L0,6L7,13L14,6L14,6ZM0,15L0,17L14,17L14,15L0,15L0,15Z" android:strokeColor="#00000000" android:strokeWidth="1"/> diff --git a/app/src/main/res/drawable/ic_find_in_page.xml b/app/src/main/res/drawable/ic_find_in_page.xml index 77acb13..085a2bf 100644 --- a/app/src/main/res/drawable/ic_find_in_page.xml +++ b/app/src/main/res/drawable/ic_find_in_page.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FFFFFFFF" android:pathData="M20,19.59V8l-6,-6H6c-1.1,0 -1.99,0.9 -1.99,2L4,20c0,1.1 0.89,2 1.99,2H18c0.45,0 0.85,-0.15 1.19,-0.4l-4.43,-4.43c-0.8,0.52 -1.74,0.83 -2.76,0.83 -2.76,0 -5,-2.24 -5,-5s2.24,-5 5,-5 5,2.24 5,5c0,1.02 -0.31,1.96 -0.83,2.75L20,19.59zM9,13c0,1.66 1.34,3 3,3s3,-1.34 3,-3 -1.34,-3 -3,-3 -3,1.34 -3,3z"/> </vector> diff --git a/app/src/main/res/drawable/ic_flag_black_24dp.xml b/app/src/main/res/drawable/ic_flag_black_24dp.xml index 4b8a250..15a3a50 100644 --- a/app/src/main/res/drawable/ic_flag_black_24dp.xml +++ b/app/src/main/res/drawable/ic_flag_black_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FF000000" android:pathData="M14.4,6L14,4H5v17h2v-7h5.6l0.4,2h7V6z"/> </vector> diff --git a/app/src/main/res/drawable/ic_image_gray_24dp.xml b/app/src/main/res/drawable/ic_image_gray_24dp.xml index afc6b5b..8203722 100644 --- a/app/src/main/res/drawable/ic_image_gray_24dp.xml +++ b/app/src/main/res/drawable/ic_image_gray_24dp.xml @@ -1,6 +1,8 @@ <vector xmlns:android="http://schemas.android.com/apk/res/android"; + xmlns:tools="http://schemas.android.com/tools"; android:autoMirrored="true" android:width="24dp" android:height="24dp" - android:viewportWidth="24.0" android:viewportHeight="24.0"> + android:viewportWidth="24.0" android:viewportHeight="24.0" + tools:ignore="UnusedAttribute"> <path android:fillColor="#FF9aa0a7" android:pathData="M21,19V5c0,-1.1 -0.9,-2 -2,-2H5c-1.1,0 -2,0.9 -2,2v14c0,1.1 0.9,2 2,2h14c1.1,0 2,-0.9 2,-2zM8.5,13.5l2.5,3.01L14.5,12l4.5,6H5l3.5,-4.5z"/> diff --git a/app/src/main/res/drawable/ic_list_white_24dp.xml b/app/src/main/res/drawable/ic_list_white_24dp.xml index cd4a67b..5f483de 100644 --- a/app/src/main/res/drawable/ic_list_white_24dp.xml +++ b/app/src/main/res/drawable/ic_list_white_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FFFFFFFF" android:pathData="M3,13h2v-2L3,11v2zM3,17h2v-2L3,15v2zM3,9h2L5,7L3,7v2zM7,13h14v-2L7,11v2zM7,17h14v-2L7,15v2zM7,7v2h14L21,7L7,7z"/> </vector> diff --git a/app/src/main/res/drawable/ic_mode_edit_white_24dp.xml b/app/src/main/res/drawable/ic_mode_edit_white_24dp.xml index 15cf3cf..7961623 100644 --- a/app/src/main/res/drawable/ic_mode_edit_white_24dp.xml +++ b/app/src/main/res/drawable/ic_mode_edit_white_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FFFFFFFF" android:pathData="M3,17.25V21h3.75L17.81,9.94l-3.75,-3.75L3,17.25zM20.71,7.04c0.39,-0.39 0.39,-1.02 0,-1.41l-2.34,-2.34c-0.39,-0.39 -1.02,-0.39 -1.41,0l-1.83,1.83 3.75,3.75 1.83,-1.83z"/> </vector> diff --git a/app/src/main/res/drawable/ic_most_read.xml b/app/src/main/res/drawable/ic_most_read.xml index b6ab380..726efbc 100644 --- a/app/src/main/res/drawable/ic_most_read.xml +++ b/app/src/main/res/drawable/ic_most_read.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" android:viewportHeight="20.0" - android:viewportWidth="20.0" android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="20.0" + android:viewportWidth="20.0" android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillAlpha="1" android:fillColor="#ffffff" android:pathData="m9.527,2.346 l4.343,0 -2.859,4.774 3.614,0 -7.93,10.384 -0.809,0 3.641,-7.579 -3.587,0z" android:strokeAlpha="1" android:strokeColor="#00000000" diff --git a/app/src/main/res/drawable/ic_restore_black_24dp.xml b/app/src/main/res/drawable/ic_restore_black_24dp.xml index b561b09..55e332f 100644 --- a/app/src/main/res/drawable/ic_restore_black_24dp.xml +++ b/app/src/main/res/drawable/ic_restore_black_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FF000000" android:pathData="M13,3c-4.97,0 -9,4.03 -9,9L1,12l3.89,3.89 0.07,0.14L9,12L6,12c0,-3.87 3.13,-7 7,-7s7,3.13 7,7 -3.13,7 -7,7c-1.93,0 -3.68,-0.79 -4.94,-2.06l-1.42,1.42C8.27,19.99 10.51,21 13,21c4.97,0 9,-4.03 9,-9s-4.03,-9 -9,-9zM12,8v5l4.28,2.54 0.72,-1.21 -3.5,-2.08L13.5,8L12,8z"/> </vector> diff --git a/app/src/main/res/drawable/ic_share_black_24dp.xml b/app/src/main/res/drawable/ic_share_black_24dp.xml index 54e85a1..66a382c 100644 --- a/app/src/main/res/drawable/ic_share_black_24dp.xml +++ b/app/src/main/res/drawable/ic_share_black_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FF000000" android:pathData="M18,16.08c-0.76,0 -1.44,0.3 -1.96,0.77L8.91,12.7c0.05,-0.23 0.09,-0.46 0.09,-0.7s-0.04,-0.47 -0.09,-0.7l7.05,-4.11c0.54,0.5 1.25,0.81 2.04,0.81 1.66,0 3,-1.34 3,-3s-1.34,-3 -3,-3 -3,1.34 -3,3c0,0.24 0.04,0.47 0.09,0.7L8.04,9.81C7.5,9.31 6.79,9 6,9c-1.66,0 -3,1.34 -3,3s1.34,3 3,3c0.79,0 1.5,-0.31 2.04,-0.81l7.12,4.16c-0.05,0.21 -0.08,0.43 -0.08,0.65 0,1.61 1.31,2.92 2.92,2.92 1.61,0 2.92,-1.31 2.92,-2.92s-1.31,-2.92 -2.92,-2.92z"/> </vector> diff --git a/app/src/main/res/drawable/ic_share_white_24dp.xml b/app/src/main/res/drawable/ic_share_white_24dp.xml index 49a9c9b..f3e3bb8 100644 --- a/app/src/main/res/drawable/ic_share_white_24dp.xml +++ b/app/src/main/res/drawable/ic_share_white_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FFFFFFFF" android:pathData="M18,16.08c-0.76,0 -1.44,0.3 -1.96,0.77L8.91,12.7c0.05,-0.23 0.09,-0.46 0.09,-0.7s-0.04,-0.47 -0.09,-0.7l7.05,-4.11c0.54,0.5 1.25,0.81 2.04,0.81 1.66,0 3,-1.34 3,-3s-1.34,-3 -3,-3 -3,1.34 -3,3c0,0.24 0.04,0.47 0.09,0.7L8.04,9.81C7.5,9.31 6.79,9 6,9c-1.66,0 -3,1.34 -3,3s1.34,3 3,3c0.79,0 1.5,-0.31 2.04,-0.81l7.12,4.16c-0.05,0.21 -0.08,0.43 -0.08,0.65 0,1.61 1.31,2.92 2.92,2.92 1.61,0 2.92,-1.31 2.92,-2.92s-1.31,-2.92 -2.92,-2.92z"/> </vector> \ No newline at end of file diff --git a/app/src/main/res/drawable/ic_sort_white_24dp.xml b/app/src/main/res/drawable/ic_sort_white_24dp.xml index 87f5054..11ca955 100644 --- a/app/src/main/res/drawable/ic_sort_white_24dp.xml +++ b/app/src/main/res/drawable/ic_sort_white_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FFFFFFFF" android:pathData="M3,18h6v-2L3,16v2zM3,6v2h18L21,6L3,6zM3,13h12v-2L3,11v2z"/> </vector> diff --git a/app/src/main/res/drawable/ic_subdirectory_arrow_right_black_24dp.xml b/app/src/main/res/drawable/ic_subdirectory_arrow_right_black_24dp.xml index e821c0e..1ff4e5a 100644 --- a/app/src/main/res/drawable/ic_subdirectory_arrow_right_black_24dp.xml +++ b/app/src/main/res/drawable/ic_subdirectory_arrow_right_black_24dp.xml @@ -1,6 +1,8 @@ <vector xmlns:android="http://schemas.android.com/apk/res/android"; + xmlns:tools="http://schemas.android.com/tools"; android:autoMirrored="true" android:width="24dp" android:height="24dp" - android:viewportWidth="24.0" android:viewportHeight="24.0"> + android:viewportWidth="24.0" android:viewportHeight="24.0" + tools:ignore="UnusedAttribute"> <path android:fillColor="#FF000000" android:pathData="M19,15l-6,6 -1.42,-1.42L15.17,16H4V4h2v10h9.17l-3.59,-3.58L13,9l6,6z"/> diff --git a/app/src/main/res/drawable/ic_translate_white_24dp.xml b/app/src/main/res/drawable/ic_translate_white_24dp.xml index 11d53b6..5a68fe0 100644 --- a/app/src/main/res/drawable/ic_translate_white_24dp.xml +++ b/app/src/main/res/drawable/ic_translate_white_24dp.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0" - android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> + android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#FFFFFFFF" android:pathData="M12.87,15.07l-2.54,-2.51 0.03,-0.03c1.74,-1.94 2.98,-4.17 3.71,-6.53L17,6L17,4h-7L10,2L8,2v2L1,4v1.99h11.17C11.5,7.92 10.44,9.75 9,11.35 8.07,10.32 7.3,9.19 6.69,8h-2c0.73,1.63 1.73,3.17 2.98,4.56l-5.09,5.02L4,19l5,-5 3.11,3.11 0.76,-2.04zM18.5,10h-2L12,22h2l1.12,-3h4.75L21,22h2l-4.5,-12zM15.88,17l1.62,-4.33L19.12,17h-3.24z"/> </vector> \ No newline at end of file diff --git a/app/src/main/res/drawable/icon_in_the_news.xml b/app/src/main/res/drawable/icon_in_the_news.xml index 305de4c..e9f3f2e 100644 --- a/app/src/main/res/drawable/icon_in_the_news.xml +++ b/app/src/main/res/drawable/icon_in_the_news.xml @@ -1,5 +1,7 @@ -<vector android:autoMirrored="true" android:height="24dp" android:viewportHeight="20.0" - android:viewportWidth="20.0" android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android";> +<vector xmlns:tools="http://schemas.android.com/tools"; + android:autoMirrored="true" android:height="24dp" android:viewportHeight="20.0" + android:viewportWidth="20.0" android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"; + tools:ignore="UnusedAttribute"> <path android:fillColor="#ffffff" android:pathData="m16.05,9.251 l-11.82,0 0,-2.111 11.82,0 0,2.111zM16.05,12.065l-5.171,0 0,-1.407 5.171,0L16.05,12.065ZM16.05,14.88 L10.878,14.88 10.878,13.473 16.05,13.473 16.05,14.88zM9.401,14.88 L4.23,14.88 4.23,10.658 9.401,10.658 9.401,14.88zM15.067,3.623 L13.833,4.798 12.6,3.623c0,0 -0.61,1.175 -1.226,1.175C10.757,4.798 10.14,3.623 10.14,3.623L8.906,4.798 7.68,3.623 6.446,4.798 5.212,3.623 3.986,4.798 2.752,3.623 2.752,14.88C2.752,15.657 3.414,16.287 4.23,16.287l11.82,0C16.866,16.287 17.527,15.657 17.527,14.88L17.527,3.623 16.293,4.798 15.067,3.623Z" android:strokeColor="#00000000" android:strokeWidth="1"/> -- To view, visit https://gerrit.wikimedia.org/r/316986 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09a0d8427bda1b4e4c1d2fa1e0df36d7aca57f09 Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
