jenkins-bot has submitted this change and it was merged.
Change subject: wikitech: Set wgMWOAuthCentralWiki = false
......................................................................
wikitech: Set wgMWOAuthCentralWiki = false
MWOauthHooks::onSetupAfterCache will set $wgMWOAuthSharedUserIDs = true
if $wgMWOAuthCentralWiki is anything other than false. This causes an
extra indirection through CentralIdLookup when creating the user in
MWOAuthUtils::getCentralUserNameFromId which is unneeded. As an
unintended side effect it will also break things by attempting to
verify the OAuth tokens and nonce twice.
Bug: T149150
Change-Id: I38e72794c4830a97fecde58d097d694e8c4ef1aa
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hashar: Looks good to me, approved
Gergő Tisza: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index a6d245d..2961682 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -3105,7 +3105,7 @@
wfLoadExtension( 'OAuth' );
if ( in_array( $wgDBname, [ 'labswiki', 'labtestwiki' ] ) ) {
// Wikitech and its testing variant use local OAuth tables
- $wgMWOAuthCentralWiki = $wgDBname;
+ $wgMWOAuthCentralWiki = false;
} else {
$wgMWOAuthCentralWiki = 'metawiki';
$wgMWOAuthSharedUserSource = 'CentralAuth';
--
To view, visit https://gerrit.wikimedia.org/r/318036
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38e72794c4830a97fecde58d097d694e8c4ef1aa
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
