Ejegg has submitted this change and it was merged.
Change subject: Fix paren nesting bug
......................................................................
Fix paren nesting bug
Just use !empty instead of counting and comparing to zero.
Change-Id: Ifb2482739000f5002af35d2306ecfb876a153ef4
---
M special/SpecialCentralNotice.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/special/SpecialCentralNotice.php b/special/SpecialCentralNotice.php
index 73fc1b1..2bc79c3 100644
--- a/special/SpecialCentralNotice.php
+++ b/special/SpecialCentralNotice.php
@@ -955,7 +955,7 @@
$htmlOut .= Xml::closeElement( 'table' );
// Create controls for campaign-associated mixins (if
there are any)
- if ( count( $wgCentralNoticeCampaignMixins > 0 ) ) {
+ if ( !empty( $wgCentralNoticeCampaignMixins ) ) {
$mixinsThisNotice =
Campaign::getCampaignMixins( $notice );
--
To view, visit https://gerrit.wikimedia.org/r/312075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb2482739000f5002af35d2306ecfb876a153ef4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
