Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/318113
Change subject: Make EntityNamespaceLookup usages more bullet proof
......................................................................
Make EntityNamespaceLookup usages more bullet proof
I would like to update this API to return null instead of false.
Change-Id: Id85314aee341d2307e6c6681d6081ec0794e5da5
---
M includes/ItemNotabilityFilter.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/13/318113/1
diff --git a/includes/ItemNotabilityFilter.php
b/includes/ItemNotabilityFilter.php
index 4e0defa..e12bfac 100644
--- a/includes/ItemNotabilityFilter.php
+++ b/includes/ItemNotabilityFilter.php
@@ -3,6 +3,7 @@
namespace ArticlePlaceholder;
use DatabaseBase;
+use ResultWrapper;
use Wikibase\Client\Store\Sql\ConsistentReadConnectionManager;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\Lib\Store\EntityNamespaceLookup;
@@ -121,7 +122,7 @@
private function selectPagePropsPage( DatabaseBase $dbr, array $itemIds
) {
$entityNamespace =
$this->entityNamespaceLookup->getEntityNamespace( 'item' );
- if ( $entityNamespace === false ) {
+ if ( !is_int( $entityNamespace ) ) {
wfLogWarning( 'EntityNamespaceLookup returns false' );
return [];
}
--
To view, visit https://gerrit.wikimedia.org/r/318113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id85314aee341d2307e6c6681d6081ec0794e5da5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
