Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319094
Change subject: Fix crash when clicking a reference in Edit Preview.
......................................................................
Fix crash when clicking a reference in Edit Preview.
This is simply because we weren't providing a bridge listener for
receiving reference click events.
This also adds a click listener for video/media objects.
Bug: T148744
Change-Id: I6335f65b7f0945bcd655a210e0e633757c04637a
---
M app/src/main/java/org/wikipedia/editing/preview/EditPreviewFragment.java
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/94/319094/1
diff --git
a/app/src/main/java/org/wikipedia/editing/preview/EditPreviewFragment.java
b/app/src/main/java/org/wikipedia/editing/preview/EditPreviewFragment.java
index 2645d59..6b5438a 100644
--- a/app/src/main/java/org/wikipedia/editing/preview/EditPreviewFragment.java
+++ b/app/src/main/java/org/wikipedia/editing/preview/EditPreviewFragment.java
@@ -263,8 +263,19 @@
bridge.addListener("imageClicked", new
CommunicationBridge.JSEventListener() {
@Override
public void onMessage(String messageType, JSONObject
messagePayload) {
- // just give it a stub message handler
- // (images will not be clickable in Preview)
+ // TODO: do something when an image is clicked in Preview.
+ }
+ });
+ bridge.addListener("mediaClicked", new
CommunicationBridge.JSEventListener() {
+ @Override
+ public void onMessage(String messageType, JSONObject
messagePayload) {
+ // TODO: do something when a video is clicked in Preview.
+ }
+ });
+ bridge.addListener("referenceClicked", new
CommunicationBridge.JSEventListener() {
+ @Override
+ public void onMessage(String messageType, JSONObject
messagePayload) {
+ // TODO: do something when a reference is clicked in
Preview.
}
});
}
--
To view, visit https://gerrit.wikimedia.org/r/319094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6335f65b7f0945bcd655a210e0e633757c04637a
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
