Marostegui has submitted this change and it was merged.

Change subject: mariadb: Added gtid_domain_id option for m2
......................................................................


mariadb: Added gtid_domain_id option for m2

This option is needed to be able to use GTID + multisource replication.
It is only needed in servers that will be masters or can be masters
at somepoint, but for consistency it is better to have it enabled in
all the hosts.
This regex will set the variable (which will only take effect on restart)
to the numeric digits on the hostname. Discarding any letter
or non numeric value.

Bug: T149418
Change-Id: I2103e5f22aa4e57d70d57a674834cea3cd0ee857
---
M templates/mariadb/misc.my.cnf.erb
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Jcrespo: Looks good to me, but someone else must approve
  Marostegui: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/templates/mariadb/misc.my.cnf.erb 
b/templates/mariadb/misc.my.cnf.erb
index e4fdf65..c6bd6bd 100644
--- a/templates/mariadb/misc.my.cnf.erb
+++ b/templates/mariadb/misc.my.cnf.erb
@@ -74,6 +74,17 @@
 <% end -%>
 aria_pagecache_buffer_size     = 512M
 
+<% if @shard == 'm2' -%>
+# gtid_domain_id flag is needed for multisource replication and GTID.
+# Strictly it is only needed on masters or servers that can potentially be
+# masters but for consistency it should be set in all of them.
+# https://mariadb.com/kb/en/mariadb/gtid/
+# The following regex removes all the non numeric characters and sets it to
+# the numbers that are part of the hostname
+
+gtid_domain_id  = <%= @server_id %>
+
+<% end -%>
 [mysqldump]
 
 quick

-- 
To view, visit https://gerrit.wikimedia.org/r/319809
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2103e5f22aa4e57d70d57a674834cea3cd0ee857
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Marostegui <maroste...@wikimedia.org>
Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org>
Gerrit-Reviewer: Marostegui <maroste...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to