Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/320185
Change subject: docker::registry: return 403 instead of 405 as an error ...................................................................... docker::registry: return 403 instead of 405 as an error This makes more sense, as we are administratively limiting access to those resources, we're not disallowing access because of lack of upstream support. Bug: T150168 Change-Id: Ifc746cd6949f53df001fb02af86049d030cd0fd1 --- M modules/docker/templates/registry-http-nginx.conf.erb 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/85/320185/1 diff --git a/modules/docker/templates/registry-http-nginx.conf.erb b/modules/docker/templates/registry-http-nginx.conf.erb index f7d6de1..9640474 100644 --- a/modules/docker/templates/registry-http-nginx.conf.erb +++ b/modules/docker/templates/registry-http-nginx.conf.erb @@ -8,16 +8,10 @@ # Tell everyone we're v2, not v1! add_header 'Docker-Distribution-Api-Version' 'registry/2.0' always; - # Handle method not allowed calls - error_page 405 @error405; - location @error405 { - add_header Allow "GET, POST, HEAD" always; - } - location / { # The HTTP endpoint cannot be used to upload images limit_except GET HEAD OPTIONS { - return 405; + deny all; } # IP whitelisting -- To view, visit https://gerrit.wikimedia.org/r/320185 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc746cd6949f53df001fb02af86049d030cd0fd1 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits