Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/320312

Change subject: Hygiene: remove verbose ArticleHeaderView methods
......................................................................

Hygiene: remove verbose ArticleHeaderView methods

Remove a couple methods that explicate ordinary operations and aren't
worthwhile

Change-Id: I1f0e722bcedfa1e13a5e952524693585ec284459
---
M app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
1 file changed, 1 insertion(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/12/320312/1

diff --git 
a/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java 
b/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
index 79893b5..8817846 100644
--- a/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
@@ -302,17 +302,9 @@
     }
 
     private void init() {
-        inflate();
-        bind();
-        hide();
-    }
-
-    private void inflate() {
         inflate(getContext(), R.layout.view_article_header, this);
-    }
-
-    private void bind() {
         ButterKnife.bind(this);
+        hide();
     }
 
     @ColorInt

-- 
To view, visit https://gerrit.wikimedia.org/r/320312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f0e722bcedfa1e13a5e952524693585ec284459
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to