jenkins-bot has submitted this change and it was merged. Change subject: (bug 44459) Implement mw.message.text(): ......................................................................
(bug 44459) Implement mw.message.text(): * Change default message format in mediawiki.js from plain to text (this includes behavior of mw.msg shorthand). * Code changes are primarily in jqueryMsg, with minor supporting changes in mediawiki. * Organize tests by public entrypoint (mediawiki or mediawiki.jqueryMsg). * Additional tests and assertions for all public entry points, for new and existing behavior. * Convenience test assertion methods * Add explanatory comments for new and existing code. * Add setting to jqueryMsg for format, defaulting to parse, to preserve existing behavior for direct callers to jqueryMsg's public API. * Since there are now two ways of constructing the abstract syntax tree, add a new parameter to the cache's key scheme. * Minor formatting Change-Id: I0d220692262356a12e2f1c0ce30cf6f090428332 --- M resources/mediawiki/mediawiki.jqueryMsg.js M resources/mediawiki/mediawiki.js M tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js M tests/qunit/suites/resources/mediawiki/mediawiki.test.js 4 files changed, 308 insertions(+), 91 deletions(-) Approvals: Ori.livneh: Looks good to me, approved Tobias Gritschacher: Looks good to me, but someone else must approve Nikerabbit: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/48601 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d220692262356a12e2f1c0ce30cf6f090428332 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org> Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org> Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: Spage <sp...@wikimedia.org> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
