jenkins-bot has submitted this change and it was merged.
Change subject: Completion preferences radio and content should be side-by-side
......................................................................
Completion preferences radio and content should be side-by-side
When very long text is used the browser ends up putting the radio div
and the content div one above the other. This is a bit of a hackish
solution, but limit the width of the content so that they stay side by
side instead of ending up one above the other.
Bug: T149982
Change-Id: I59fc3f090a63bf41db84e7c6499ceed6a532482e
---
M includes/HTMLCompletionProfileSettings.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Deskana: Looks good to me, approved
Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/HTMLCompletionProfileSettings.php
b/includes/HTMLCompletionProfileSettings.php
index 9bc9657..801eae2 100644
--- a/includes/HTMLCompletionProfileSettings.php
+++ b/includes/HTMLCompletionProfileSettings.php
@@ -35,7 +35,7 @@
* @param string $value
* @return string
*/
- function getInputHTML( $value ) {
+ public function getInputHTML( $value ) {
$html = Html::openElement( 'div' );
$html .= Html::element( 'legend',
[],
@@ -87,7 +87,7 @@
}
$html .= Html::input( $this->mName, $prof, 'radio', $radioAttrs
);
$html .= Html::closeElement( 'div' );
- $html .= Html::openElement( 'div', [ 'style' =>
'display:inline-block' ] );
+ $html .= Html::openElement( 'div', [ 'style' =>
'display:inline-block; width: 90%' ] );
$html .= Html::element( 'label',
['for' => $radioId, 'style' => 'font-weight: bold'],
wfMessage(
"cirrussearch-completion-profile-$prof-pref-name" )->text()
--
To view, visit https://gerrit.wikimedia.org/r/320701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59fc3f090a63bf41db84e7c6499ceed6a532482e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Cindy-the-browser-test-bot <bernhardsone...@gmail.com>
Gerrit-Reviewer: DCausse <dcau...@wikimedia.org>
Gerrit-Reviewer: Deskana <dga...@wikimedia.org>
Gerrit-Reviewer: Gehel <gleder...@wikimedia.org>
Gerrit-Reviewer: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: Tjones <tjo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
