Marostegui has submitted this change and it was merged. Change subject: mariadb: Deploy gtid_domain_id to all the misc shards ......................................................................
mariadb: Deploy gtid_domain_id to all the misc shards This option is needed to be able to use GTID + multisource replication. It is only needed in servers that will be masters or can be masters at somepoint, but for consistency it is better to have it enabled in all the hosts. This has been enabled in m2 for 3 days and worked fine. I want to enable it for the rest of the shards. This variable will only take effect on restart or if applied manually which I intend to do for a few slaves. I have also updated the comment as it was referring to an old regex that was abandoned after some discussion. Bug: T149418 Change-Id: Ib111a15cdc1dbf8dd2c8555ef5122d7acbcb9c88 --- M templates/mariadb/misc.my.cnf.erb 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jcrespo: Looks good to me, but someone else must approve Marostegui: Looks good to me, approved jenkins-bot: Verified diff --git a/templates/mariadb/misc.my.cnf.erb b/templates/mariadb/misc.my.cnf.erb index 33b3ec1..d58bd51 100644 --- a/templates/mariadb/misc.my.cnf.erb +++ b/templates/mariadb/misc.my.cnf.erb @@ -92,17 +92,13 @@ <% end -%> aria_pagecache_buffer_size = 512M -<% if @shard == 'm2' -%> # gtid_domain_id flag is needed for multisource replication and GTID. # Strictly it is only needed on masters or servers that can potentially be # masters but for consistency it should be set in all of them. # https://mariadb.com/kb/en/mariadb/gtid/ -# The following regex removes all the non numeric characters and sets it to -# the numbers that are part of the hostname gtid_domain_id = <%= @server_id %> -<% end -%> <% if @ssl == 'on' %> # ssl ssl-ca=/etc/mysql/ssl/cacert.pem -- To view, visit https://gerrit.wikimedia.org/r/320731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib111a15cdc1dbf8dd2c8555ef5122d7acbcb9c88 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Marostegui <maroste...@wikimedia.org> Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org> Gerrit-Reviewer: Marostegui <maroste...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
