jenkins-bot has submitted this change and it was merged. Change subject: Fix failing PHPUnit tests ......................................................................
Fix failing PHPUnit tests These test failures were caused by I5c0b554e7. Change-Id: If950786aa130cb9dd39982065de3d8842919060e --- M tests/phpunit/HTMLFeatureFieldTest.php M tests/phpunit/NewHTMLCheckFieldTest.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/HTMLFeatureFieldTest.php b/tests/phpunit/HTMLFeatureFieldTest.php index 74466ff..ecb4d72 100644 --- a/tests/phpunit/HTMLFeatureFieldTest.php +++ b/tests/phpunit/HTMLFeatureFieldTest.php @@ -45,7 +45,7 @@ 'message' => 'Table row with class name not found.', ), array( - 'pattern' => "#<input type='checkbox' tabindex='0' aria-disabled='false' name='wpblahblahblah' value='1' class='oo-ui-inputWidget-input'>#", + 'pattern' => "#<input type='checkbox' tabindex='0' aria-disabled='false' name='wpblahblahblah' value='1' class='oo-ui-inputWidget-input' />#", 'message' => 'Styled checkbox input not found.', ), array( diff --git a/tests/phpunit/NewHTMLCheckFieldTest.php b/tests/phpunit/NewHTMLCheckFieldTest.php index 9d02a6e..3aa6f65 100644 --- a/tests/phpunit/NewHTMLCheckFieldTest.php +++ b/tests/phpunit/NewHTMLCheckFieldTest.php @@ -38,7 +38,7 @@ $html = $form->getHTML( false ); $this->assertRegExp( '#<tr class="mw-htmlform-field-NewHTMLCheckField">#', $html, 'Table row with class name not found.' ); - $this->assertRegExp( "#<input type='checkbox' tabindex='0' aria-disabled='false' name='wpblahblahblah' value='1' checked='checked' class='oo-ui-inputWidget-input'>#", $html, 'Styled input not found.' ); + $this->assertRegExp( "#<input type='checkbox' tabindex='0' aria-disabled='false' name='wpblahblahblah' value='1' checked='checked' class='oo-ui-inputWidget-input' />#", $html, 'Styled input not found.' ); $this->assertRegExp( "#<span class='oo-ui-labelElement-label'>blah blah blah</span>#", $html, 'Checkbox label not found.' ); } } -- To view, visit https://gerrit.wikimedia.org/r/320751 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If950786aa130cb9dd39982065de3d8842919060e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BetaFeatures Gerrit-Branch: master Gerrit-Owner: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits