01tonythomas has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320765
Change subject: Correct return of ArticleDelete hook implmentation
......................................................................
Correct return of ArticleDelete hook implmentation
Bug: T150399
Change-Id: I59bd64b51a87963c98de4289c41bbfe22db7c8eb
---
M Newsletter.hooks.php
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/65/320765/1
diff --git a/Newsletter.hooks.php b/Newsletter.hooks.php
index 4536962..2c8ebe7 100755
--- a/Newsletter.hooks.php
+++ b/Newsletter.hooks.php
@@ -198,14 +198,15 @@
$success = NewsletterStore::getDefaultInstance()
->deleteNewsletter( $newsletter, $reason );
if ( $success ) {
- return $status->newGood();
+ $status->newGood();
} else {
// Show error message and allow resubmitting in
case of failure
- return $status->newFatal(
+ $status->newFatal(
$wgOut->msg(
'newsletter-delete-failure' )->rawParams( $newsletter->getName() )
);
}
+ return false;
}
- return true;
+ return false;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/320765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59bd64b51a87963c98de4289c41bbfe22db7c8eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <01tonytho...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
