Tim Starling has uploaded a new change for review. https://gerrit.wikimedia.org/r/48615
Change subject: Fix ustring issues under LuaSandbox ...................................................................... Fix ustring issues under LuaSandbox Found these issues just trying to run the unit tests. * Fixed E_STRICT error in declaration of UstringLibraryNormalizationTestProvider::run(). * Fixed PHP fatal error "Using $this when not in object context" due to $this not being passed to the closure in ustringGmatch(). * Removed test for unicode character above U+10FFF failing isutf8(), the mb_check_encoding() implementation does not pass. * Fixed test for len() of an invalid string to actually use an input which mb_check_encoding() considers invalid. Change-Id: Ida4959769ebd94683a424262a66da4d2ca23b374 --- M engines/LuaCommon/UstringLibrary.php M tests/engines/LuaCommon/UstringLibraryTest.php M tests/engines/LuaCommon/UstringLibraryTests.lua 3 files changed, 7 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto refs/changes/15/48615/1 -- To view, visit https://gerrit.wikimedia.org/r/48615 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida4959769ebd94683a424262a66da4d2ca23b374 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Scribunto Gerrit-Branch: master Gerrit-Owner: Tim Starling <tstarl...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
