Yaron Koren has submitted this change and it was merged. Change subject: Simplified RL loading for Special:CreateTemplate ......................................................................
Simplified RL loading for Special:CreateTemplate Change-Id: Icbb8ba413a4f2c5f7de9ac075cb78f6c1cc668d8 --- M specials/PF_CreateTemplate.php 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Yaron Koren: Looks good to me, approved jenkins-bot: Verified diff --git a/specials/PF_CreateTemplate.php b/specials/PF_CreateTemplate.php index e870d07..6c81baa 100644 --- a/specials/PF_CreateTemplate.php +++ b/specials/PF_CreateTemplate.php @@ -137,11 +137,6 @@ return $text; } - function addJavascript() { - $out = $this->getOutput(); - $out->addModules( array( 'ext.pageforms.PF_CreateTemplate' ) ); - } - static function printTemplateStyleButton( $formatStr, $formatMsg, $htmlFieldName, $curSelection ) { $attrs = array( 'id' => $formatStr ); if ( $formatStr === $curSelection ) { @@ -175,8 +170,7 @@ $template_name = $req->getVal( 'template_name' ); } - $out->addModules( 'ext.pageforms.main' ); - $this->addJavascript(); + $out->addModules( array( 'ext.pageforms.main', 'ext.pageforms.PF_CreateTemplate' ) ); $text = ''; $save_page = $req->getCheck( 'wpSave' ); -- To view, visit https://gerrit.wikimedia.org/r/320836 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbb8ba413a4f2c5f7de9ac075cb78f6c1cc668d8 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/PageForms Gerrit-Branch: master Gerrit-Owner: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits