Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321335
Change subject: Remove whitelist_nicks
......................................................................
Remove whitelist_nicks
The users intended to be allowed by this list are all eligible for cloaks,
which require actual authentication and can therefore be trusted.
This couldn't.
Change-Id: I3e24f40f19f4e9902688b4a39b0b8aacc85938ea
---
M src/relay.js
1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/grrrit
refs/changes/35/321335/1
diff --git a/src/relay.js b/src/relay.js
index af57f11..8f40d87 100644
--- a/src/relay.js
+++ b/src/relay.js
@@ -169,11 +169,6 @@
ircClient.addListener('message', function (from, to, text) {
var whitelist_cloaks =
/^((mediawiki|wikimedia|wikipedia|wiktionary|wikiquote|wikisource|wikispecies|wikibooks|wikinews|wikiversity|wikivoyage|wikidata|wikimedia-commons)\/|fsf\/member\/marktraceur$)/g;
- var whitelist_nicks = [
- "twentyafterfour",
- "thcipriani"
- ];
-
ircClient.whois(from, function(info){
try {
@@ -184,11 +179,7 @@
var $irc_nick1;
var $irc_nick2 = config.nick.indexOf(ircClient.nick) >= 0;
- if (info.host) {
- $irc_nick1 = (info.host.match(whitelist_cloaks) ||
whitelist_nicks.indexOf(from) >= 0);
- } else {
- $irc_nick1 = whitelist_nicks.indexOf(from) >= 0;
- }
+ $irc_nick1 = info.host ? info.host.match(whitelist_cloaks) : false;
if ($irc_nick_restart && $irc_nick1) {
console.log(from + ' => ' + to + ' ' + text);
--
To view, visit https://gerrit.wikimedia.org/r/321335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e24f40f19f4e9902688b4a39b0b8aacc85938ea
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/grrrit
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <a...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
