Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321380
Change subject: Fix logging of 'load' in UploadWizardTutorialActions
......................................................................
Fix logging of 'load' in UploadWizardTutorialActions
Only log this when the tutorial step is loaded, not when any step is
loaded... I don't think anyone really uses this data.
Change-Id: I1008995ffc9b568d2890f7fbfa7f6c49e2a2e551
---
M resources/controller/uw.controller.Step.js
M resources/controller/uw.controller.Tutorial.js
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/80/321380/1
diff --git a/resources/controller/uw.controller.Step.js
b/resources/controller/uw.controller.Step.js
index 9eda8e4..6cc3fe9 100644
--- a/resources/controller/uw.controller.Step.js
+++ b/resources/controller/uw.controller.Step.js
@@ -115,7 +115,6 @@
} );
this.ui.moveTo( uploads );
- uw.eventFlowLogger.logTutorialAction( 'load' );
uw.eventFlowLogger.logStep( this.stepName );
this.updateFileCounts( this.uploads );
diff --git a/resources/controller/uw.controller.Tutorial.js
b/resources/controller/uw.controller.Tutorial.js
index 2965694..41b66e1 100644
--- a/resources/controller/uw.controller.Tutorial.js
+++ b/resources/controller/uw.controller.Tutorial.js
@@ -80,6 +80,11 @@
} );
};
+ uw.controller.Tutorial.prototype.moveTo = function ( uploads ) {
+ uw.controller.Step.prototype.moveTo.call( this, uploads );
+ uw.eventFlowLogger.logTutorialAction( 'load' );
+ };
+
uw.controller.Tutorial.prototype.moveNext = function () {
uw.eventFlowLogger.logTutorialAction( 'continue' );
--
To view, visit https://gerrit.wikimedia.org/r/321380
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1008995ffc9b568d2890f7fbfa7f6c49e2a2e551
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
