jenkins-bot has submitted this change and it was merged.
Change subject: Always allow write mode in API tests
......................................................................
Always allow write mode in API tests
This may be unrelated to T150512, but it can't hurt to always set this
to true. The only thing this boolean flag does is *disabling* an additional
permission check, which is perfectly fine in a test environment.
Bug: T150512
Change-Id: I823e7275261dc0bfc87273a8b61d7784b95bf9e2
---
M repo/tests/phpunit/includes/Api/ApiFormatTestCase.php
M repo/tests/phpunit/includes/Api/ApiModuleTestHelper.php
M repo/tests/phpunit/includes/Api/CreateRedirectTest.php
M repo/tests/phpunit/includes/Api/IndependentWikibaseApiTestCase.php
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Hoo man: Looks good to me, but someone else must approve
Nikerabbit: Looks good to me, but someone else must approve
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/Api/ApiFormatTestCase.php
b/repo/tests/phpunit/includes/Api/ApiFormatTestCase.php
index 0c76b53..9a8baed 100644
--- a/repo/tests/phpunit/includes/Api/ApiFormatTestCase.php
+++ b/repo/tests/phpunit/includes/Api/ApiFormatTestCase.php
@@ -50,7 +50,7 @@
$params['token'] = $wgUser->getEditToken();
}
$request = new FauxRequest( $params, true );
- $main = new ApiMain( $request );
+ $main = new ApiMain( $request, true );
return new $moduleClass( $main, $moduleName );
}
diff --git a/repo/tests/phpunit/includes/Api/ApiModuleTestHelper.php
b/repo/tests/phpunit/includes/Api/ApiModuleTestHelper.php
index cdf4b89..fb17167 100644
--- a/repo/tests/phpunit/includes/Api/ApiModuleTestHelper.php
+++ b/repo/tests/phpunit/includes/Api/ApiModuleTestHelper.php
@@ -37,7 +37,7 @@
}
$request = new FauxRequest( $params, true );
- $main = new ApiMain( $request );
+ $main = new ApiMain( $request, true );
$main->getContext()->setUser( $user );
if ( is_string( $instantiator ) && class_exists( $instantiator
) ) {
diff --git a/repo/tests/phpunit/includes/Api/CreateRedirectTest.php
b/repo/tests/phpunit/includes/Api/CreateRedirectTest.php
index 0351b86..d343ece 100644
--- a/repo/tests/phpunit/includes/Api/CreateRedirectTest.php
+++ b/repo/tests/phpunit/includes/Api/CreateRedirectTest.php
@@ -118,7 +118,7 @@
}
$request = new FauxRequest( $params, true );
- $main = new ApiMain( $request );
+ $main = new ApiMain( $request, true );
$main->getContext()->setUser( $user );
$module = new CreateRedirect( $main, 'wbcreateredirect' );
diff --git a/repo/tests/phpunit/includes/Api/IndependentWikibaseApiTestCase.php
b/repo/tests/phpunit/includes/Api/IndependentWikibaseApiTestCase.php
index 6bd5df8..c6caf08 100644
--- a/repo/tests/phpunit/includes/Api/IndependentWikibaseApiTestCase.php
+++ b/repo/tests/phpunit/includes/Api/IndependentWikibaseApiTestCase.php
@@ -101,7 +101,7 @@
$request = new FauxRequest( $params, true,
$wgRequest->getSessionArray() );
$requestContext->setRequest( $request );
- $apiMain = new ApiMain( $requestContext );
+ $apiMain = new ApiMain( $requestContext, true );
$class = $this->getModuleClass();
return new $class( $apiMain, 'iAmAName' );
--
To view, visit https://gerrit.wikimedia.org/r/321625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I823e7275261dc0bfc87273a8b61d7784b95bf9e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
