Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/322104
Change subject: Check for unitsuggester in browsertests ...................................................................... Check for unitsuggester in browsertests Bug: T150161 Change-Id: Ie9b82d85d6455ed408810b8bc15a3baacbf6cd86 --- M tests/browser/features/statements_quantity.feature M tests/browser/features/step_definitions/statement_steps.rb M tests/browser/features/support/modules/statement_module.rb 3 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/04/322104/1 diff --git a/tests/browser/features/statements_quantity.feature b/tests/browser/features/statements_quantity.feature index 43989cc..4b6dd21 100644 --- a/tests/browser/features/statements_quantity.feature +++ b/tests/browser/features/statements_quantity.feature @@ -23,6 +23,7 @@ And I enter 1 in the claim value input field Then Statement save button should be there And Statement cancel button should be there + And Unit suggester should be there @ui_only Scenario Outline: Check quantity UI for invalid values diff --git a/tests/browser/features/step_definitions/statement_steps.rb b/tests/browser/features/step_definitions/statement_steps.rb index 5000fe2..1bea7c1 100644 --- a/tests/browser/features/step_definitions/statement_steps.rb +++ b/tests/browser/features/step_definitions/statement_steps.rb @@ -296,3 +296,7 @@ Then(/^InputExtender dropdown should be there$/) do expect(on(ItemPage).inputextender_dropdown_element.when_visible).to be_visible end + +Then(/^Unit suggester should be there$/) do + expect(on(ItemPage).inputextender_unitsuggester_element.when_visible).to be_visible +end diff --git a/tests/browser/features/support/modules/statement_module.rb b/tests/browser/features/support/modules/statement_module.rb index aba3011..1936474 100644 --- a/tests/browser/features/support/modules/statement_module.rb +++ b/tests/browser/features/support/modules/statement_module.rb @@ -29,6 +29,7 @@ div(:inputextender_preview, css: 'div.ui-inputextender-extension > div.ui-preview > div.ui-preview-value') text_field(:inputextender_input, css: 'div.ui-inputextender-extension > input') + text_field(:inputextender_unitsuggester, css: 'div.ui-inputextender-extension > .ui-unitsuggester-input') span(:time_hint, css: 'div.ui-inputextender-extension > div.valueview-expertextender-calendarhint > span') a(:time_precision, css: 'div.ui-inputextender-extension div.valueview-expert-TimeInput-precision > a.ui-listrotator-curr') a(:time_calendar, css: 'div.ui-inputextender-extension div.valueview-expert-TimeInput-calendar > a.ui-listrotator-curr') -- To view, visit https://gerrit.wikimedia.org/r/322104 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9b82d85d6455ed408810b8bc15a3baacbf6cd86 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits