jenkins-bot has submitted this change and it was merged.
Change subject: visibilitychange: Consider all changes to imply hidden
......................................................................
visibilitychange: Consider all changes to imply hidden
Previously we only emitted "hidden" if the visibilitychange event
was emitted to change state from visible to hidden, not if it
changed from visible to hidden.
It shouldn't make any difference since we already check the initial
value as well. To verify that this doesn't matter, this commit
simplifies the code by removing the document.hidden check from
the change event handler. See also I8e8ec96fc.
Change-Id: Ibd0935bef8f76a0e1a675db5242e2d4e301b0233
(cherry picked from commit c1714315a9459bf1cd8f2752d11675fc2765595d)
---
M modules/ext.wikimediaEvents.visibilitychange.js
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.wikimediaEvents.visibilitychange.js
b/modules/ext.wikimediaEvents.visibilitychange.js
index 473cebd..8378a4d 100644
--- a/modules/ext.wikimediaEvents.visibilitychange.js
+++ b/modules/ext.wikimediaEvents.visibilitychange.js
@@ -33,8 +33,8 @@
}
- function check() {
- if ( document[ hidden ] === true && !( mwLoadEnd &&
document.readyState === 'complete' ) ) {
+ function changeHandler() {
+ if ( !( mwLoadEnd && document.readyState === 'complete' ) ) {
trackOnce( 'hidden' );
}
}
@@ -64,8 +64,11 @@
return;
}
- check();
- document.addEventListener( eventName, check, false );
+ document.addEventListener( eventName, changeHandler, false );
+ // Initial value
+ if ( document[ hidden ] === true ) {
+ trackOnce( 'hidden' );
+ }
trackOnce( 'supported' );
if ( vendor ) {
trackOnce( 'vendor' );
--
To view, visit https://gerrit.wikimedia.org/r/322023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd0935bef8f76a0e1a675db5242e2d4e301b0233
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.29.0-wmf.3
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
