Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322787
Change subject: Exclude bots from edit count
......................................................................
Exclude bots from edit count
Bug: T145554
Change-Id: I5764455f14ab4baffcc89aec3539d0bfb8aa8392
---
M lib/processor.js
M test/lib/processor.js
2 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/trending-edits
refs/changes/87/322787/1
diff --git a/lib/processor.js b/lib/processor.js
index 10ed461..7e3518b 100644
--- a/lib/processor.js
+++ b/lib/processor.js
@@ -19,8 +19,11 @@
var page;
var id = edit.page_id;
var ts = edit.rev_timestamp;
+ var performer = edit.performer;
- if (edit.meta.topic === 'mediawiki.revision-create' && edit.page_namespace
=== 0 ) {
+ if (edit.meta.topic === 'mediawiki.revision-create' &&
+ !performer.user_is_bot && edit.page_namespace === 0
+ ) {
if (pages[id]) {
pages[id].edits++;
pages[id].updated = ts;
diff --git a/test/lib/processor.js b/test/lib/processor.js
index 0a6f2ed..355693a 100644
--- a/test/lib/processor.js
+++ b/test/lib/processor.js
@@ -3,7 +3,7 @@
var assert = require('./../utils/assert.js');
var processor = require('./../../lib/processor.js');
-function edit( id, username, ts, ns ) {
+function edit( id, username, ts, ns, isBot ) {
return {
comment: '',
meta: { topic: "mediawiki.revision-create" },
@@ -12,7 +12,7 @@
page_title: 'Foo',
performer: {
user_groups: ["*"],
- user_is_bot: false,
+ user_is_bot: isBot,
user_text: username || '10.0.2.2'
},
rev_id: 5,
@@ -28,11 +28,12 @@
processor.process( edit( 1, 'Corey', '2016-11-15T18:02:55+00:00' ) );
processor.process( edit( 1, 'Bernd', '2016-11-15T18:03:55+00:00' ) );
processor.process( edit( 2, 'Talker', '2016-11-15T18:03:55+00:00', 1 ) );
+ processor.process( edit( 1, 'Bot', '2016-11-15T18:03:55+00:00', 0, true )
);
it('check events are combined for articles in main namespace', function() {
var pages = processor.getPages();
assert.ok( pages.length === 1, 'Pages with same name are combined into
single page' );
- assert.ok( pages[0].edits === 3, 'Edits are counted' );
+ assert.ok( pages[0].edits === 3, 'Edits are counted for all non-bot
edits' );
assert.ok( pages[0].title === 'Foo', 'Title is present' );
assert.ok( pages[0].updated === '2016-11-15T18:03:55+00:00', 'Updated
is timestamp of last edit' );
assert.ok( pages[0].from === '2016-11-15T18:00:55+00:00', 'from is
timestamp of first recorded edit' );
--
To view, visit https://gerrit.wikimedia.org/r/322787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5764455f14ab4baffcc89aec3539d0bfb8aa8392
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
