Yaron Koren has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322824
Change subject: Fix for setting "tables" query string for download formats
......................................................................
Fix for setting "tables" query string for download formats
Change-Id: I15029688ce05701b0b7e17bfaaa479d1e381bab9
---
M formats/CargoDeferredFormat.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo
refs/changes/24/322824/2
diff --git a/formats/CargoDeferredFormat.php b/formats/CargoDeferredFormat.php
index 3a8abd5..a21c4bf 100644
--- a/formats/CargoDeferredFormat.php
+++ b/formats/CargoDeferredFormat.php
@@ -30,7 +30,7 @@
return null;
} elseif ( count( $sqlQueries ) == 1 ) {
$sqlQuery = $sqlQueries[0];
- $queryParams['tables'] = implode( ',',
$sqlQuery->mTableNames );
+ $queryParams['tables'] = $sqlQuery->mTablesStr;
if ( $sqlQuery->mJoinOnStr != '' ) {
$queryParams['join on'] = $sqlQuery->mJoinOnStr;
}
@@ -54,7 +54,7 @@
}
} else {
foreach ( $sqlQueries as $i => $sqlQuery ) {
- $queryParams['tables'][] = implode( ',',
$sqlQuery->mTableNames );
+ $queryParams['tables'][] =
$sqlQuery->mTablesStr;
$queryParams['join on'][] =
$sqlQuery->mJoinOnStr;
$queryParams['fields'][] =
$sqlQuery->mFieldsStr;
$queryParams['where'][] = $sqlQuery->mWhereStr;
--
To view, visit https://gerrit.wikimedia.org/r/322824
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15029688ce05701b0b7e17bfaaa479d1e381bab9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
