Dzahn has submitted this change and it was merged. Change subject: Phab: Remove pointless variable assignment ......................................................................
Phab: Remove pointless variable assignment Change-Id: Ic2451c273307ff424796e55870b2cce9f55eca40 --- M modules/role/manifests/phabricator/main.pp 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Dzahn: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/role/manifests/phabricator/main.pp b/modules/role/manifests/phabricator/main.pp index cd7ea43..b215aad 100644 --- a/modules/role/manifests/phabricator/main.pp +++ b/modules/role/manifests/phabricator/main.pp @@ -181,7 +181,6 @@ } include exim4::ganglia - $emailbotcert = $passwords::phabricator::emailbot_cert class { '::phabricator::mailrelay': default => { security => 'users', @@ -196,12 +195,11 @@ domains => 'markmonitor.com,wikimedia.org', procurement => 'cdw.com,cyrusone.com,dasher.com,dell.com,globalsign.com,optiv.com,unitedlayer.com,us.ntt.net,wikimedia.org,zayo.com', }, - phab_bot => { root_dir => '/srv/phab/phabricator/', username => 'emailbot', host => "https://${domain}/api/", - certificate => $emailbotcert, + certificate => $passwords::phabricator::emailbot_cert, }, } -- To view, visit https://gerrit.wikimedia.org/r/323081 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2451c273307ff424796e55870b2cce9f55eca40 Gerrit-PatchSet: 6 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Chad <ch...@wikimedia.org> Gerrit-Reviewer: 20after4 <mmod...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits