Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323155
Change subject: Avoid calling EntityId::newFromNumber when not necessary
......................................................................
Avoid calling EntityId::newFromNumber when not necessary
Change-Id: I2eee08fbf3237fefff786eec87517f2d12ccaa05
---
M tests/phpunit/includes/AboutTopicRendererTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/55/323155/1
diff --git a/tests/phpunit/includes/AboutTopicRendererTest.php
b/tests/phpunit/includes/AboutTopicRendererTest.php
index b699f1f..e0d9c7f 100644
--- a/tests/phpunit/includes/AboutTopicRendererTest.php
+++ b/tests/phpunit/includes/AboutTopicRendererTest.php
@@ -205,7 +205,7 @@
$siteLinkLookup->expects( $this->any() )
->method( 'getSiteLinksForItem' )
- ->with( ItemId::newFromNumber( '123' ) )
+ ->with( new ItemId( 'Q123' ) )
->will(
$this->returnValue( [
new SiteLink( 'eowiki', 'Unicorn' ),
--
To view, visit https://gerrit.wikimedia.org/r/323155
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2eee08fbf3237fefff786eec87517f2d12ccaa05
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
