Robert Vogel has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/323415

Change subject: BSReview: Added Reload of BsReviewProcess after update db row
......................................................................

BSReview: Added Reload of BsReviewProcess after update db row

* The BsReviewProcess was never considered ->finished(). This Propably fixes a 
ton of known bugs like "No mail after workflow finish"

=> NEEDS Cherry-Pick to REL1_27 and REL1_23

Change-Id: I713fede2568ed037a236e4f51caa8f3adb00810e
---
M Review/Review.class.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/15/323415/1

diff --git a/Review/Review.class.php b/Review/Review.class.php
index f245e40..2b7eab4 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1306,6 +1306,10 @@
                $dbw->update( 'bs_review_steps', $data, array( 'revs_id' => 
$step_id ) );
 
                $oTitle->invalidateCache();
+               //RELOAD ReviewProcess!
+               $oReviewProcess = BsReviewProcess::newFromPid(
+                       (int) $oTitle->getArticleID()
+               );
 
                if ( $sVote == 'no' ) {
                        if ( $oReviewProcess->isSequential() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/323415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I713fede2568ed037a236e4f51caa8f3adb00810e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: Robert Vogel <vo...@hallowelt.biz>
Gerrit-Reviewer: Pwirth <wi...@hallowelt.biz>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to