jenkins-bot has submitted this change and it was merged. Change subject: BSReview: Added Reload of BsReviewProcess after update db row ......................................................................
BSReview: Added Reload of BsReviewProcess after update db row * The BsReviewProcess was never considered ->finished(). This Propably fixes a ton of known bugs like "No mail after workflow finish" => NEEDS Cherry-Pick to REL1_27 and REL1_23 Change-Id: I713fede2568ed037a236e4f51caa8f3adb00810e --- M Review/Review.class.php 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Robert Vogel: Looks good to me, approved jenkins-bot: Verified diff --git a/Review/Review.class.php b/Review/Review.class.php index 3a58f0f..2a0c73f 100644 --- a/Review/Review.class.php +++ b/Review/Review.class.php @@ -1352,6 +1352,10 @@ $dbw->update( 'bs_review_steps', $data, array( 'revs_id' => $step_id ) ); $oTitle->invalidateCache(); + //RELOAD ReviewProcess! + $oReviewProcess = BsReviewProcess::newFromPid( + (int) $oTitle->getArticleID() + ); if ( $sVote == 'no' ) { if ( $oReviewProcess->isSequential() ) { -- To view, visit https://gerrit.wikimedia.org/r/323170 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I713fede2568ed037a236e4f51caa8f3adb00810e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions Gerrit-Branch: master Gerrit-Owner: Pwirth <wi...@hallowelt.biz> Gerrit-Reviewer: Dvogel hallowelt <daniel.vo...@hallowelt.com> Gerrit-Reviewer: Ljonka <l.verhovs...@gmail.com> Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz> Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits