jenkins-bot has submitted this change and it was merged.

Change subject: parserTests: flag articles creation as internal
......................................................................


parserTests: flag articles creation as internal

When the parser test suite creates articles, there is no need to check
whether it has been pre parsed in stash edit. That is quite spammy in
the debug log and always a cache miss.

Bypass the cache lookup by passing EDIT_INTERNAL to doEditContent()

Change-Id: I27e212ab1a76ebcf25b383514c9ad8ad0b28383c
---
M tests/parser/ParserTestRunner.php
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/parser/ParserTestRunner.php 
b/tests/parser/ParserTestRunner.php
index 04c142a..281e1df 100644
--- a/tests/parser/ParserTestRunner.php
+++ b/tests/parser/ParserTestRunner.php
@@ -1508,7 +1508,11 @@
                // get a reference to the mock object.
                MessageCache::singleton()->getParser();
                $restore = $this->executeSetupSnippets( [ 'wgParser' => new 
ParserTestMockParser ] );
-               $status = $page->doEditContent( ContentHandler::makeContent( 
$text, $title ), '', EDIT_NEW );
+               $status = $page->doEditContent(
+                       ContentHandler::makeContent( $text, $title ),
+                       '',
+                       EDIT_NEW | EDIT_INTERNAL
+               );
                $restore();
 
                if ( !$status->isOK() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/323398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27e212ab1a76ebcf25b383514c9ad8ad0b28383c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: C. Scott Ananian <canan...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to