Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323897
Change subject: Track newly created pages
......................................................................
Track newly created pages
Bug: T145554
Change-Id: If71d673ac24fb229798d2c697f45b2e1deaf11cd
---
M lib/processor.js
M test/features/lib/processor.js
2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/trending-edits
refs/changes/97/323897/1
diff --git a/lib/processor.js b/lib/processor.js
index 9d6dce1..3a95100 100644
--- a/lib/processor.js
+++ b/lib/processor.js
@@ -89,6 +89,7 @@
totalPages++;
pages[id] = {
id: id,
+ isNew: edit.rev_parent_id === undefined,
edits: 1,
from: ts,
updated: ts,
diff --git a/test/features/lib/processor.js b/test/features/lib/processor.js
index c497493..31dcc58 100644
--- a/test/features/lib/processor.js
+++ b/test/features/lib/processor.js
@@ -56,6 +56,7 @@
performer: performer,
rev_id: 5,
rev_len: 200,
+ rev_parent_id: 4,
rev_minor_edit: false,
rev_timestamp: ts
}, data );
@@ -99,6 +100,7 @@
assert.ok( pages[0].contributors.names.Jon.edits === 2, 'Edits by Jon
counted' );
assert.ok( pages[0].contributors.names['127.0.0.5'].edits === 1,
'Edits by anon counted' );
assert.ok( pages[0].contributors.main === 'Bernd', 'Top editor
recorded' );
+ assert.ok( pages[0].isNew === false, 'False isNew flag for pages with
parent id' );
assert.ok( pages[0].bias === 3 / 8,
'Bias is total edits by main author divided by total edits. The
lower the less bias.' );
});
@@ -153,6 +155,17 @@
var pages = processor.getPages();
assert.ok( pages.length === 0, 'The store is empty.' );
});
+
+ it('A newly created page has a isNew flag', function() {
+ var event = edit( 3, 'Jon', '2016-11-15T18:00:55+00:00' );
+ delete event.rev_parent_id;
+
+ processor.reset();
+ processor.process( event );
+
+ var pages = processor.getPages();
+ assert.ok( processor.getPages()[0].isNew, 'A flag is present.' );
+ });
});
describe('processor - initial state', function() {
--
To view, visit https://gerrit.wikimedia.org/r/323897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If71d673ac24fb229798d2c697f45b2e1deaf11cd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
