Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325083
Change subject: Choose the best image
......................................................................
Choose the best image
Follow up to If6cbb82f01fa298945c615a2f25e972a9d767d58
Change-Id: I5e46985bfd22b2f96eb659a3d14137bdadbc4b99
(cherry picked from commit 9215a7f9d91433d6873ece7e9fd9bfdba1bc2414)
---
M includes/PageImages.php
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageImages
refs/changes/83/325083/1
diff --git a/includes/PageImages.php b/includes/PageImages.php
index be36510..8081ffa 100644
--- a/includes/PageImages.php
+++ b/includes/PageImages.php
@@ -39,16 +39,16 @@
*/
public static function getPageImage( Title $title ) {
$dbr = wfGetDB( DB_SLAVE );
- $name = $dbr->selectFieldValues( 'page_props',
- 'pp_value',
+ $fileName = $dbr->selectField( 'page_props',
+ [ 'pp_value' ],
[ 'pp_page' => $title->getArticleID(), 'pp_propname' =>
[ self::PROP_NAME, self::PROP_NAME_FREE ] ],
- __METHOD__
+ __METHOD__,
+ [ 'ORDER BY' => 'pp_propname' ]
);
$file = false;
-
- if ( $name ) {
- $file = wfFindFile( $name[0] );
+ if ( $fileName ) {
+ $file = wfFindFile( $fileName );
}
return $file;
--
To view, visit https://gerrit.wikimedia.org/r/325083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e46985bfd22b2f96eb659a3d14137bdadbc4b99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageImages
Gerrit-Branch: wmf/1.29.0-wmf.4
Gerrit-Owner: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
