Jcrespo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/325301

Change subject: labsdb: Add minor fixes for maintain-dbusers schema
......................................................................

labsdb: Add minor fixes for maintain-dbusers schema

* Syntax error on comma ',' before the ')' end table definition
* Explicitly enforce InnoDB engine (non needed, noop, but just in
  case)

Bug: T149933
Change-Id: I43c5345fdf05af12d46df105a9d4bc90acaed615
---
M modules/role/files/labs/db/maintain-dbusers.sql
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/01/325301/1

diff --git a/modules/role/files/labs/db/maintain-dbusers.sql 
b/modules/role/files/labs/db/maintain-dbusers.sql
index da867b7..37c2ccb 100644
--- a/modules/role/files/labs/db/maintain-dbusers.sql
+++ b/modules/role/files/labs/db/maintain-dbusers.sql
@@ -8,13 +8,13 @@
     mysql_username VARCHAR(255) NOT NULL,
     type enum('tool', 'user') NOT NULL,
     username VARCHAR(255) NOT NULL,
-    password VARCHAR(255) NOT NULL,
-) CHARSET=utf8mb4;
+    password VARCHAR(255) NOT NULL
+) ENGINE=InnoDB CHARSET=utf8mb4;
 CREATE UNIQUE INDEX account_type ON accounts(type, username);
 
 CREATE TABLE account_hosts(
     id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT,
     account_id INT UNSIGNED NOT NULL,
-    hostname VARCHAR(255) NOT NULL,
-) CHARSET=utf8mb4;
+    hostname VARCHAR(255) NOT NULL
+) ENGINE=InnoDB CHARSET=utf8mb4;
 CREATE INDEX account_host_status ON accounts(account_id, hostname);

-- 
To view, visit https://gerrit.wikimedia.org/r/325301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43c5345fdf05af12d46df105a9d4bc90acaed615
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo <jcre...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to