jenkins-bot has submitted this change and it was merged. Change subject: FieldsetLayout: Temporarily remove use of `<legend>` due to Chrome 55 bug ......................................................................
FieldsetLayout: Temporarily remove use of `<legend>` due to Chrome 55 bug Chrome 55 has a major regression where `<legend>` tags styled with 'float' disappear, and those styled with `display: inline-block` etc. appear to the side of the parent instead of on top. Both bugs affect us, and the buggy version just recently got promoted into stable. https://bugs.chromium.org/p/chromium/issues/detail?id=661230 https://bugs.chromium.org/p/chromium/issues/detail?id=670837 I intend to revert this as soon as the Chrome bug is fixed. Bug: T151061 Change-Id: I73f95965694ec7fb0fa9a474742286e1105e5c85 --- M php/layouts/FieldsetLayout.php M src/layouts/FieldsetLayout.js 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/php/layouts/FieldsetLayout.php b/php/layouts/FieldsetLayout.php index 2a6bb8c..74182eb 100644 --- a/php/layouts/FieldsetLayout.php +++ b/php/layouts/FieldsetLayout.php @@ -27,7 +27,7 @@ // Traits $this->initializeIconElement( $config ); $this->initializeLabelElement( array_merge( $config, [ - 'labelElement' => new Tag( 'legend' ) + 'labelElement' => new Tag( 'div' ) ] ) ); $this->initializeGroupElement( $config ); diff --git a/src/layouts/FieldsetLayout.js b/src/layouts/FieldsetLayout.js index 8c4411a..2974b27 100644 --- a/src/layouts/FieldsetLayout.js +++ b/src/layouts/FieldsetLayout.js @@ -54,7 +54,7 @@ // Mixin constructors OO.ui.mixin.IconElement.call( this, config ); - OO.ui.mixin.LabelElement.call( this, $.extend( {}, config, { $label: $( '<legend>' ) } ) ); + OO.ui.mixin.LabelElement.call( this, $.extend( {}, config, { $label: $( '<div>' ) } ) ); OO.ui.mixin.GroupElement.call( this, config ); if ( config.help ) { -- To view, visit https://gerrit.wikimedia.org/r/325243 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73f95965694ec7fb0fa9a474742286e1105e5c85 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: VolkerE <volke...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
