Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325320
Change subject: Revert "FieldsetLayout: Temporarily remove use of `<legend>`
due to Chrome 55 bug"
......................................................................
Revert "FieldsetLayout: Temporarily remove use of `<legend>` due to Chrome 55
bug"
This reverts commit e5823869189940bd50d74d40f57d8180b8942d79.
Change-Id: I51b16df4878bd4560988b501185aadcb18959614
---
M php/layouts/FieldsetLayout.php
M src/layouts/FieldsetLayout.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/20/325320/1
diff --git a/php/layouts/FieldsetLayout.php b/php/layouts/FieldsetLayout.php
index 74182eb..2a6bb8c 100644
--- a/php/layouts/FieldsetLayout.php
+++ b/php/layouts/FieldsetLayout.php
@@ -27,7 +27,7 @@
// Traits
$this->initializeIconElement( $config );
$this->initializeLabelElement( array_merge( $config, [
- 'labelElement' => new Tag( 'div' )
+ 'labelElement' => new Tag( 'legend' )
] ) );
$this->initializeGroupElement( $config );
diff --git a/src/layouts/FieldsetLayout.js b/src/layouts/FieldsetLayout.js
index 2974b27..8c4411a 100644
--- a/src/layouts/FieldsetLayout.js
+++ b/src/layouts/FieldsetLayout.js
@@ -54,7 +54,7 @@
// Mixin constructors
OO.ui.mixin.IconElement.call( this, config );
- OO.ui.mixin.LabelElement.call( this, $.extend( {}, config, { $label: $(
'<div>' ) } ) );
+ OO.ui.mixin.LabelElement.call( this, $.extend( {}, config, { $label: $(
'<legend>' ) } ) );
OO.ui.mixin.GroupElement.call( this, config );
if ( config.help ) {
--
To view, visit https://gerrit.wikimedia.org/r/325320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51b16df4878bd4560988b501185aadcb18959614
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
